bug #34954 [Mailer] Fixed undefined index when sending via Mandrill API (wulff)

nicolas-grekas · nicolas-grekas · commit 07bfe6bae5e2 · 2019-12-17T11:26:47.000+01:00
This PR was merged into the 4.4 branch. Discussion ---------- [Mailer] Fixed undefined index when sending via Mandrill API | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #34892 | License | MIT When a [Mandrill API send request](https://www.mandrillapp.com/api/docs/messages.JSON.html#method=send) is succesful, it returns an array of results, one for each recipient. To get rid of the undefined index error, we grab the message ID from the first recipient in the array. Commits ------- ef0aa4d [Mailer] fixed undefined index when sending mail
diff --git a/src/Symfony/Component/Mailer/Bridge/Mailchimp/Transport/MandrillApiTransport.php b/src/Symfony/Component/Mailer/Bridge/Mailchimp/Transport/MandrillApiTransport.php
@@ -57,7 +57,8 @@ protected function doSendApi(SentMessage $sentMessage, Email $email, Envelope $e
             throw new HttpTransportException(sprintf('Unable to send an email (code %s).', $result['code']), $response);
         }
 
-        $sentMessage->setMessageId($result['_id']);
+        $firstRecipient = reset($result);
+        $sentMessage->setMessageId($firstRecipient['_id']);
 
         return $response;
     }

Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,8 @@ protected function doSendApi(SentMessage $sentMessage, Email $email, Envelope $e`
`57`	`57`	`throw new HttpTransportException(sprintf('Unable to send an email (code %s).', $result['code']), $response);`
`58`	`58`	`}`
`59`	`59`
`60`		`- $sentMessage->setMessageId($result['_id']);`
	`60`	`+ $firstRecipient = reset($result);`
	`61`	`+ $sentMessage->setMessageId($firstRecipient['_id']);`
`61`	`62`
`62`	`63`	`return $response;`
`63`	`64`	`}`