Prevent from using Lazy with Autowire

Tiriel · Tiriel · commit 091395a65477 · 2024-01-11T17:55:49.000+01:00
diff --git a/src/Symfony/Component/DependencyInjection/Compiler/AutowirePass.php b/src/Symfony/Component/DependencyInjection/Compiler/AutowirePass.php
@@ -300,7 +300,14 @@ private function autowireMethod(\ReflectionFunctionAbstract $reflectionMethod, a
             };
 
             if ($checkAttributes) {
-                $attributes = $parameter->getAttributes(Autowire::class, \ReflectionAttribute::IS_INSTANCEOF) + $parameter->getAttributes(Lazy::class, \ReflectionAttribute::IS_INSTANCEOF);
+                $autowire = $parameter->getAttributes(Autowire::class, \ReflectionAttribute::IS_INSTANCEOF);
+                $lazy = $parameter->getAttributes(Lazy::class, \ReflectionAttribute::IS_INSTANCEOF);
+
+                if (\count($autowire) > 0 && \count($lazy) > 0) {
+                    throw new AutowiringFailedException($this->currentId, "'Lazy' and 'Autowire' attributes cannot be used on the same argument.");
+                }
+
+                $attributes = $autowire + $lazy;
                 foreach ($attributes as $attribute) {
                     $attribute = $attribute->newInstance();
                     $invalidBehavior = $parameter->allowsNull() ? ContainerInterface::NULL_ON_INVALID_REFERENCE : ContainerBuilder::EXCEPTION_ON_INVALID_REFERENCE;
diff --git a/src/Symfony/Component/DependencyInjection/Tests/Compiler/AutowirePassTest.php b/src/Symfony/Component/DependencyInjection/Tests/Compiler/AutowirePassTest.php
@@ -1380,4 +1380,17 @@ public function testLazyServiceAttribute()
         $expected = new Reference('.lazy.'.A::class);
         $this->assertEquals($expected, $container->getDefinition('foo')->getArgument(0));
     }
+
+    public function testLazyNotCompatibleWithAutowire()
+    {
+        $container = new ContainerBuilder();
+        $container->register('a', A::class)->setAutowired(true);
+        $container->register('foo', LazyAutowireServiceAttributesAutowiring::class)->setAutowired(true);
+
+        try {
+            (new AutowirePass())->process($container);
+        } catch (AutowiringFailedException $e) {
+            $this->assertSame("'Lazy' and 'Autowire' attributes cannot be used on the same argument.", $e->getMessage());
+        }
+    }
 }
diff --git a/src/Symfony/Component/DependencyInjection/Tests/Fixtures/includes/autowiring_classes_80.php b/src/Symfony/Component/DependencyInjection/Tests/Fixtures/includes/autowiring_classes_80.php
@@ -133,3 +133,10 @@ public function __construct(#[Lazy] A $a)
     {
     }
 }
+
+class LazyAutowireServiceAttributesAutowiring
+{
+    public function __construct(#[Lazy]#[Autowire(lazy: true)] A $a)
+    {
+    }
+}

Original file line number	Diff line number	Diff line change
`@@ -133,3 +133,10 @@ public function __construct(#[Lazy] A $a)`
`133`	`133`	`{`
`134`	`134`	`}`
`135`	`135`	`}`
	`136`	`+`
	`137`	`+class LazyAutowireServiceAttributesAutowiring`
	`138`	`+{`
	`139`	`+ public function __construct(#[Lazy]#[Autowire(lazy: true)] A $a)`
	`140`	`+ {`
	`141`	`+ }`
	`142`	`+}`