[FileSystem] remove symlinks under windows

Erik Trapman · Erik Trapman · commit 0b58828b3f8c · 2012-06-13T10:40:20.000+02:00
diff --git a/src/Symfony/Component/Filesystem/Filesystem.php b/src/Symfony/Component/Filesystem/Filesystem.php
@@ -94,7 +94,9 @@ public function remove($files)
 
             if (is_dir($file) && !is_link($file)) {
                 $this->remove(new \FilesystemIterator($file));
-
+                rmdir($file);
+            } elseif(is_dir($file) && is_link($file)) {
+                // https://bugs.php.net/bug.php?id=52176 windows thinks symlinks are directories
                 rmdir($file);
             } else {
                 unlink($file);
diff --git a/src/Symfony/Component/Filesystem/Tests/FilesystemTest.php b/src/Symfony/Component/Filesystem/Tests/FilesystemTest.php
@@ -421,6 +421,20 @@ public function testSymlink()
         $this->assertTrue(is_link($link));
         $this->assertEquals($file, readlink($link));
     }
+    
+    /**
+     * @depends testSymlink 
+     */
+    public function testRemoveSymlink()
+    {
+        $this->markAsSkippedIfSymlinkIsMissing();
+        
+        $link = $this->workspace.DIRECTORY_SEPARATOR.'link';
+        
+        $this->filesystem->remove($link);
+        
+        $this->assertTrue(!is_link($link));
+    }
 
     public function testSymlinkIsOverwrittenIfPointsToDifferentTarget()
     {
