Add a way to filter direct children

Einenlum · Einenlum · commit 0bc09b89a4d2 · 2018-08-17T19:43:46.000+02:00
diff --git a/src/Symfony/Component/DomCrawler/Crawler.php b/src/Symfony/Component/DomCrawler/Crawler.php
@@ -501,16 +501,26 @@ public function parents()
     /**
      * Returns the children nodes of the current selection.
      *
+     * @param $selector string|null A optional CSS selector to filter children
+     *
      * @return self
      *
      * @throws \InvalidArgumentException When current node is empty
+     * @throws \RuntimeException if the CssSelector Component is not available and $selector is provided
      */
-    public function children()
+    public function children($selector = null)
     {
         if (!$this->nodes) {
             throw new \InvalidArgumentException('The current node list is empty.');
         }
 
+        if ($selector) {
+            $converter = $this->createCssSelectorConverter($this->isHtml);
+            $xpath = $converter->toXPath($selector, 'child::*/');
+
+            return $this->filterXPath($xpath);
+        }
+
         $node = $this->getNode(0)->firstChild;
 
         return $this->createSubCrawler($node ? $this->sibling($node) : array());
@@ -691,11 +701,7 @@ public function filterXPath($xpath)
      */
     public function filter($selector)
     {
-        if (!class_exists(CssSelectorConverter::class)) {
-            throw new \RuntimeException('To filter with a CSS selector, install the CssSelector component ("composer require symfony/css-selector"). Or use filterXpath instead.');
-        }
-
-        $converter = new CssSelectorConverter($this->isHtml);
+        $converter = $this->createCssSelectorConverter($this->isHtml);
 
         // The CssSelector already prefixes the selector with descendant-or-self::
         return $this->filterRelativeXPath($converter->toXPath($selector));
@@ -1148,4 +1154,20 @@ private function createSubCrawler($nodes)
 
         return $crawler;
     }
+
+    /**
+     * @param bool $html Whether HTML support should be enabled. Disable it for XML documents
+     *
+     * @return CssSelectorConverter A CssSelectorConverter instance
+     *
+     * @throws \RuntimeException if the CssSelector Component is not available
+     */
+    private function createCssSelectorConverter(bool $isHtml)
+    {
+        if (!class_exists(CssSelectorConverter::class)) {
+            throw new \RuntimeException('To filter with a CSS selector, install the CssSelector component ("composer require symfony/css-selector"). Or use filterXpath instead.');
+        }
+
+        return new CssSelectorConverter($isHtml);
+    }
 }
diff --git a/src/Symfony/Component/DomCrawler/Tests/CrawlerTest.php b/src/Symfony/Component/DomCrawler/Tests/CrawlerTest.php
@@ -1004,6 +1004,37 @@ public function testChildren()
         }
     }
 
+    public function testFilteredChildren()
+    {
+        $html = <<<'HTML'
+<!DOCTYPE html>
+<html lang="en">
+<body>
+    <div id="foo">
+        <div class="lorem">
+            <p class="lorem"></p>
+        </div>
+        <div class="lorem">
+            <span class="lorem"></span>
+        </div>
+        <span class="ipsum"></span>
+    </div>
+</body>
+</html>
+HTML;
+
+        $crawler = new Crawler($html);
+        $foo = $crawler->filter('#foo');
+
+        $this->assertEquals(3, $foo->children()->count());
+        $this->assertEquals(2, $foo->children('.lorem')->count());
+        $this->assertEquals(2, $foo->children('div')->count());
+        $this->assertEquals(2, $foo->children('div.lorem')->count());
+        $this->assertEquals(1, $foo->children('span')->count());
+        $this->assertEquals(1, $foo->children('span.ipsum')->count());
+        $this->assertEquals(1, $foo->children('.ipsum')->count());
+    }
+
     public function testParents()
     {
         $crawler = $this->createTestCrawler()->filterXPath('//li[1]');
