[PropertyAccess] Fix accessing public property in Object

kevcomparadise · kevcomparadise · commit 0cc177fe7ec1 · 2021-12-03T12:40:08.000+01:00
New test Dynamic property with magic getter
diff --git a/src/Symfony/Component/PropertyAccess/Tests/Fixtures/TestPublicPropertyGetterOnObjectMagicGet.php b/src/Symfony/Component/PropertyAccess/Tests/Fixtures/TestPublicPropertyGetterOnObjectMagicGet.php
@@ -0,0 +1,16 @@
+<?php
+
+namespace Symfony\Component\PropertyAccess\Tests\Fixtures;
+
+class TestPublicPropertyGetterOnObjectMagicGet
+{
+    public $a = 'A';
+    private $b = 'B';
+
+    public function __get(string $propoerty)
+    {
+        if ($propoerty === 'b') {
+            return $this->b;
+        }
+    }
+}
diff --git a/src/Symfony/Component/PropertyAccess/Tests/PropertyAccessorTest.php b/src/Symfony/Component/PropertyAccess/Tests/PropertyAccessorTest.php
@@ -33,6 +33,7 @@
 use Symfony\Component\PropertyAccess\Tests\Fixtures\TestClassTypeErrorInsideCall;
 use Symfony\Component\PropertyAccess\Tests\Fixtures\TestPublicPropertyDynamicallyCreated;
 use Symfony\Component\PropertyAccess\Tests\Fixtures\TestPublicPropertyGetterOnObject;
+use Symfony\Component\PropertyAccess\Tests\Fixtures\TestPublicPropertyGetterOnObjectMagicGet;
 use Symfony\Component\PropertyAccess\Tests\Fixtures\TestSingularAndPluralProps;
 use Symfony\Component\PropertyAccess\Tests\Fixtures\Ticket5775Object;
 use Symfony\Component\PropertyAccess\Tests\Fixtures\TypeHinted;
@@ -974,4 +975,20 @@ public function testGetDynamicPublicProperty()
 
         $this->assertSame($value, $this->propertyAccessor->getValue($object, $path));
     }
+
+    public function testGetDynamicPublicPropertyWithMagicGetterDisallow()
+    {
+        $this->expectException(NoSuchPropertyException::class);
+        $object = new TestPublicPropertyGetterOnObjectMagicGet();
+        $propertyAccessor = new PropertyAccessor(PropertyAccessor::DISALLOW_MAGIC_METHODS);
+        $propertyAccessor->getValue($object, 'c');
+    }
+
+    public function testGetDynamicPublicPropertyWithMagicGetterAllow()
+    {
+        $value = 'B';
+        $path = 'b';
+        $object = new TestPublicPropertyGetterOnObjectMagicGet();
+        $this->assertSame($value, $this->propertyAccessor->getValue($object, $path));
+    }
 }
