[Form] Remove useless intl_get_error_code() call

roukmoute · roukmoute · commit 0cd8d7248468 · 2026-01-19T12:07:56.000+01:00
Fix #63113 (review)
diff --git a/src/Symfony/Component/Form/Extension/Core/DataTransformer/DateTimeToLocalizedStringTransformer.php b/src/Symfony/Component/Form/Extension/Core/DataTransformer/DateTimeToLocalizedStringTransformer.php
@@ -215,12 +215,11 @@ private function parse(\IntlDateFormatter $dateFormatter, string $value): int|fl
         // If parsing failed and the value contains regular spaces, try with ICU 72+ whitespace
         if ((false === $timestamp || 0 !== intl_get_error_code()) && str_contains($value, ' ')) {
             $icuValue = str_replace(' ', self::NARROW_NO_BREAK_SPACE, $value);
-            intl_get_error_code(); // Clear previous error
 
             try {
                 $timestamp = @$dateFormatter->parse($icuValue);
             } catch (\IntlException) {
-                // Ignore, we'll use the original error below
+                // Ignore and return the failed timestamp
             }
         }
 
diff --git a/src/Symfony/Component/Form/Tests/Extension/Core/DataTransformer/DateTimeToLocalizedStringTransformerTest.php b/src/Symfony/Component/Form/Tests/Extension/Core/DataTransformer/DateTimeToLocalizedStringTransformerTest.php
@@ -238,7 +238,7 @@ public function testReverseTransformFromDifferentLocale()
 
         $transformer = new DateTimeToLocalizedStringTransformer('UTC', 'UTC');
 
-        $this->assertDateTimeEquals($this->dateTimeWithoutSeconds, $transformer->reverseTransform('Feb 3, 2010, 4:05 AM'));
+        $this->assertDateTimeEquals($this->dateTimeWithoutSeconds, $transformer->reverseTransform('Feb 3, 2010, 04:05 AM'));
     }
 
     public function testReverseTransformWithDifferentTimezones()

Original file line number	Diff line number	Diff line change
`@@ -215,12 +215,11 @@ private function parse(\IntlDateFormatter $dateFormatter, string $value): int\|fl`
`215`	`215`	`// If parsing failed and the value contains regular spaces, try with ICU 72+ whitespace`
`216`	`216`	`if ((false === $timestamp \|\| 0 !== intl_get_error_code()) && str_contains($value, ' ')) {`
`217`	`217`	`$icuValue = str_replace(' ', self::NARROW_NO_BREAK_SPACE, $value);`
`218`		`- intl_get_error_code(); // Clear previous error`
`219`	`218`
`220`	`219`	`try {`
`221`	`220`	`$timestamp = @$dateFormatter->parse($icuValue);`
`222`	`221`	`} catch (\IntlException) {`
`223`		`- // Ignore, we'll use the original error below`
	`222`	`+ // Ignore and return the failed timestamp`
`224`	`223`	`}`
`225`	`224`	`}`
`226`	`225`
Original file line number	Diff line number	Diff line change
`@@ -238,7 +238,7 @@ public function testReverseTransformFromDifferentLocale()`
`238`	`238`
`239`	`239`	`$transformer = new DateTimeToLocalizedStringTransformer('UTC', 'UTC');`
`240`	`240`
`241`		`- $this->assertDateTimeEquals($this->dateTimeWithoutSeconds, $transformer->reverseTransform('Feb 3, 2010, 4:05 AM'));`
	`241`	`+ $this->assertDateTimeEquals($this->dateTimeWithoutSeconds, $transformer->reverseTransform('Feb 3, 2010, 04:05 AM'));`
`242`	`242`	`}`
`243`	`243`
`244`	`244`	`public function testReverseTransformWithDifferentTimezones()`