delete '?:' who are used only to increase perf with big regex

jenaye · jenaye · commit 0ce89f6e5e38 · 2018-02-21T15:29:07.000+01:00
diff --git a/src/Symfony/Bundle/WebProfilerBundle/DependencyInjection/Configuration.php b/src/Symfony/Bundle/WebProfilerBundle/DependencyInjection/Configuration.php
@@ -38,7 +38,7 @@ public function getConfigTreeBuilder()
             ->children()
                 ->booleanNode('toolbar')->defaultFalse()->end()
                 ->booleanNode('intercept_redirects')->defaultFalse()->end()
-                ->scalarNode('excluded_ajax_paths')->defaultValue('^/((?:index|app(_[\w]+)?)\.php/)?_wdt')->end()
+                ->scalarNode('excluded_ajax_paths')->defaultValue('^/((index|app(_[\w]+)?)\.php/)?_wdt')->end()
             ->end()
         ;
 
diff --git a/src/Symfony/Bundle/WebProfilerBundle/Tests/DependencyInjection/ConfigurationTest.php b/src/Symfony/Bundle/WebProfilerBundle/Tests/DependencyInjection/ConfigurationTest.php
@@ -32,9 +32,9 @@ public function testConfigTree($options, $results)
     public function getDebugModes()
     {
         return array(
-            array(array(), array('intercept_redirects' => false, 'toolbar' => false, 'excluded_ajax_paths' => '^/((?:index|app(_[\w]+)?)\.php/)?_wdt')),
-            array(array('intercept_redirects' => true), array('intercept_redirects' => true, 'toolbar' => false, 'excluded_ajax_paths' => '^/((?:index|app(_[\w]+)?)\.php/)?_wdt')),
-            array(array('intercept_redirects' => false), array('intercept_redirects' => false, 'toolbar' => false, 'excluded_ajax_paths' => '^/((?:index|app(_[\w]+)?)\.php/)?_wdt')),
+            array(array(), array('intercept_redirects' => false, 'toolbar' => false, 'excluded_ajax_paths' => '^/((index|app(_[\w]+)?)\.php/)?_wdt')),
+            array(array('intercept_redirects' => true), array('intercept_redirects' => true, 'toolbar' => false, 'excluded_ajax_paths' => '^/((index|app(_[\w]+)?)\.php/)?_wdt')),
+            array(array('intercept_redirects' => false), array('intercept_redirects' => false, 'toolbar' => false, 'excluded_ajax_paths' => '^/((index|app(_[\w]+)?)\.php/)?_wdt')),
             array(array('toolbar' => true), array('intercept_redirects' => false, 'toolbar' => true, 'excluded_ajax_paths' => '^/((?:index|app(_[\w]+)?)\.php/)?_wdt')),
             array(array('excluded_ajax_paths' => 'test'), array('intercept_redirects' => false, 'toolbar' => false, 'excluded_ajax_paths' => 'test')),
         );

Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ public function getConfigTreeBuilder()`
`38`	`38`	`->children()`
`39`	`39`	`->booleanNode('toolbar')->defaultFalse()->end()`
`40`	`40`	`->booleanNode('intercept_redirects')->defaultFalse()->end()`
`41`		`- ->scalarNode('excluded_ajax_paths')->defaultValue('^/((?:index\|app(_[\w]+)?)\.php/)?_wdt')->end()`
	`41`	`+ ->scalarNode('excluded_ajax_paths')->defaultValue('^/((index\|app(_[\w]+)?)\.php/)?_wdt')->end()`
`42`	`42`	`->end()`
`43`	`43`	`;`
`44`	`44`