Improve CS in HttpFoundationExtension

vudaltsov · vudaltsov · commit 0ff821970565 · 2019-04-07T11:20:10.000+02:00
diff --git a/src/Symfony/Bridge/Twig/Extension/HttpFoundationExtension.php b/src/Symfony/Bridge/Twig/Extension/HttpFoundationExtension.php
@@ -44,13 +44,12 @@ public function __construct($urlHelper)
 
         @trigger_error(sprintf('Passing a "%s" instance as the first argument to the "%s" constructor is deprecated since Symfony 4.3, pass a "%s" instance instead.', RequestStack::class, __CLASS__, UrlHelper::class), E_USER_DEPRECATED);
 
+        $requestContext = null;
         if (2 === \func_num_args()) {
             $requestContext = \func_get_arg(1);
             if (!$requestContext instanceof RequestContext) {
                 throw new \TypeError(sprintf('The second argument must be an instance of "%s".', RequestContext::class));
             }
-        } else {
-            $requestContext = null;
         }
 
         $this->urlHelper = new UrlHelper($urlHelper, $requestContext);

Original file line number	Diff line number	Diff line change
`@@ -44,13 +44,12 @@ public function __construct($urlHelper)`
`44`	`44`
`45`	`45`	`@trigger_error(sprintf('Passing a "%s" instance as the first argument to the "%s" constructor is deprecated since Symfony 4.3, pass a "%s" instance instead.', RequestStack::class, __CLASS__, UrlHelper::class), E_USER_DEPRECATED);`
`46`	`46`
	`47`	`+ $requestContext = null;`
`47`	`48`	`if (2 === \func_num_args()) {`
`48`	`49`	`$requestContext = \func_get_arg(1);`
`49`	`50`	`if (!$requestContext instanceof RequestContext) {`
`50`	`51`	`throw new \TypeError(sprintf('The second argument must be an instance of "%s".', RequestContext::class));`
`51`	`52`	`}`
`52`		`- } else {`
`53`		`- $requestContext = null;`
`54`	`53`	`}`
`55`	`54`
`56`	`55`	`$this->urlHelper = new UrlHelper($urlHelper, $requestContext);`