Revert "[HttpKernel] Throw a LogicException when kernel.exception does not led to a Response"

nicolas-grekas · nicolas-grekas · commit 10c5ffbdd09e · 2015-04-24T09:21:43.000+02:00
This partially reverts commit 22f4807.
diff --git a/src/Symfony/Component/HttpKernel/HttpKernel.php b/src/Symfony/Component/HttpKernel/HttpKernel.php
@@ -229,10 +229,6 @@ private function handleException(\Exception $e, $request, $type)
         if (!$event->hasResponse()) {
             $this->finishRequest($request, $type);
 
-            if ($this->dispatcher->hasListeners(KernelEvents::EXCEPTION)) {
-                throw new \LogicException('No listeners of the "kernel.exception" event set a Response', 0, $e);
-            }
-
             throw $e;
         }
 
diff --git a/src/Symfony/Component/HttpKernel/Tests/HttpKernelTest.php b/src/Symfony/Component/HttpKernel/Tests/HttpKernelTest.php
@@ -151,7 +151,7 @@ public function testHandleWhenNoControllerIsFound()
         $dispatcher = new EventDispatcher();
         $kernel = new HttpKernel($dispatcher, $this->getResolver(false));
 
-        $kernel->handle(new Request(), HttpKernelInterface::MASTER_REQUEST, false);
+        $kernel->handle(new Request());
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -229,10 +229,6 @@ private function handleException(\Exception $e, $request, $type)`
`229`	`229`	`if (!$event->hasResponse()) {`
`230`	`230`	`$this->finishRequest($request, $type);`
`231`	`231`
`232`		`- if ($this->dispatcher->hasListeners(KernelEvents::EXCEPTION)) {`
`233`		`- throw new \LogicException('No listeners of the "kernel.exception" event set a Response', 0, $e);`
`234`		`- }`
`235`		`-`
`236`	`232`	`throw $e;`
`237`	`233`	`}`
`238`	`234`
Original file line number	Diff line number	Diff line change
`@@ -151,7 +151,7 @@ public function testHandleWhenNoControllerIsFound()`
`151`	`151`	`$dispatcher = new EventDispatcher();`
`152`	`152`	`$kernel = new HttpKernel($dispatcher, $this->getResolver(false));`
`153`	`153`
`154`		`- $kernel->handle(new Request(), HttpKernelInterface::MASTER_REQUEST, false);`
	`154`	`+ $kernel->handle(new Request());`
`155`	`155`	`}`
`156`	`156`
`157`	`157`	`/**`