Issue 5288 fix

istaveren · istaveren · commit 12a890f7cb5f · 2012-11-24T15:42:58.000+01:00
diff --git a/src/Symfony/Component/Locale/Tests/Stub/StubNumberFormatterTest.php b/src/Symfony/Component/Locale/Tests/Stub/StubNumberFormatterTest.php
@@ -210,7 +210,7 @@ public function testFormatCurrencyWithCurrencyStyleBrazilianRealRoundingIntl($va
 
     public function formatCurrencyWithCurrencyStyleBrazilianRealRoundingProvider()
     {
-        $brl = $this->isIntlExtensionLoaded() && $this->isSameAsIcuVersion('4.8') ? 'BR' : 'R';
+        $brl = $this->isIntlExtensionLoaded() && $this->isGreaterOrEqualThanIcuVersion('4.8') ? 'BR' : 'R';
 
         return array(
             array(100, 'BRL', $brl, '%s$100.00'),
diff --git a/src/Symfony/Component/Locale/Tests/TestCase.php b/src/Symfony/Component/Locale/Tests/TestCase.php
@@ -89,7 +89,16 @@ protected function isLowerThanIcuVersion($version)
 
     protected function normalizeIcuVersion($version)
     {
-        return ((float) $version) * 100;
+        $versionIds = explode(".", $version);
+
+        $multi = 1000;
+        $intVersion = 0;
+        foreach ($versionIds as $id) {
+          $intVersion += $id * $multi;
+          $multi = $multi/10;
+        }
+
+        return (int) $intVersion;
     }
 
     protected function getIntlExtensionIcuVersion()

Original file line number	Diff line number	Diff line change
`@@ -210,7 +210,7 @@ public function testFormatCurrencyWithCurrencyStyleBrazilianRealRoundingIntl($va`
`210`	`210`
`211`	`211`	`public function formatCurrencyWithCurrencyStyleBrazilianRealRoundingProvider()`
`212`	`212`	`{`
`213`		`- $brl = $this->isIntlExtensionLoaded() && $this->isSameAsIcuVersion('4.8') ? 'BR' : 'R';`
	`213`	`+ $brl = $this->isIntlExtensionLoaded() && $this->isGreaterOrEqualThanIcuVersion('4.8') ? 'BR' : 'R';`
`214`	`214`
`215`	`215`	`return array(`
`216`	`216`	`array(100, 'BRL', $brl, '%s$100.00'),`