Fix coding standards

zairigimad · zairigimad · commit 13ba8ad9512e · 2019-02-07T21:51:13.000+01:00
diff --git a/src/Symfony/Component/Validator/Constraints/Json.php b/src/Symfony/Component/Validator/Constraints/Json.php
@@ -21,11 +21,11 @@
  */
 class Json extends Constraint
 {
-    const NOT_JSON_ERROR = '0789c8ad-2d2b-49a4-8356-e2ce63998504';
+    const INVALID_JSON_ERROR = '0789c8ad-2d2b-49a4-8356-e2ce63998504';
 
-    protected static $errorNames = array(
-        self::NOT_JSON_ERROR => 'NOT_JSON_ERROR',
-    );
+    protected static $errorNames = [
+        self::INVALID_JSON_ERROR => 'INVALID_JSON_ERROR',
+    ];
 
     public $message = 'This value should be valid JSON.';
 }
diff --git a/src/Symfony/Component/Validator/Constraints/JsonValidator.php b/src/Symfony/Component/Validator/Constraints/JsonValidator.php
@@ -44,7 +44,7 @@ public function validate($value, Constraint $constraint)
         if (JSON_ERROR_NONE !== json_last_error()) {
             $this->context->buildViolation($constraint->message)
                 ->setParameter('{{ value }}', $this->formatValue($value))
-                ->setCode(Json::NOT_JSON_ERROR)
+                ->setCode(Json::INVALID_JSON_ERROR)
                 ->addViolation();
         }
     }
diff --git a/src/Symfony/Component/Validator/Tests/Constraints/JsonValidatorTest.php b/src/Symfony/Component/Validator/Tests/Constraints/JsonValidatorTest.php
@@ -37,41 +37,41 @@ public function testJsonIsValid($value)
      */
     public function testInvalidValues($value)
     {
-        $constraint = new Json(array(
+        $constraint = new Json([
             'message' => 'myMessageTest',
-        ));
+        ]);
 
         $this->validator->validate($value, $constraint);
 
         $this->buildViolation('myMessageTest')
             ->setParameter('{{ value }}', '"'.$value.'"')
-            ->setCode(Json::NOT_JSON_ERROR)
+            ->setCode(Json::INVALID_JSON_ERROR)
             ->assertRaised();
     }
 
     public function getValidValues()
     {
-        return array(
-            array('{"planet":"earth", "country": "Morocco","city": "Rabat" ,"postcode" : 10160, "is_great": true,
-			  "img" : null, "area": 118.5, "foo": 15 }'),
-            array(null),
-            array(''),
-            array('"null"'),
-            array('null'),
-            array('"string"'),
-            array('1'),
-            array('true'),
-            array(1),
-        );
+        return [
+            ['{"planet":"earth", "country": "Morocco","city": "Rabat" ,"postcode" : 10160, "is_great": true,
+			  "img" : null, "area": 118.5, "foo": 15 }'],
+            [null],
+            [''],
+            ['"null"'],
+            ['null'],
+            ['"string"'],
+            ['1'],
+            ['true'],
+            [1],
+        ];
     }
 
     public function getInvalidValues()
     {
-        return array(
-            array('{"foo": 3 "bar": 4}'),
-            array('{"foo": 3 ,"bar": 4'),
-            array('{foo": 3, "bar": 4}'),
-            array('foo'),
-        );
+        return [
+            ['{"foo": 3 "bar": 4}'],
+            ['{"foo": 3 ,"bar": 4'],
+            ['{foo": 3, "bar": 4}'],
+            ['foo'],
+        ];
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -21,11 +21,11 @@`
`21`	`21`	`*/`
`22`	`22`	`class Json extends Constraint`
`23`	`23`	`{`
`24`		`- const NOT_JSON_ERROR = '0789c8ad-2d2b-49a4-8356-e2ce63998504';`
	`24`	`+ const INVALID_JSON_ERROR = '0789c8ad-2d2b-49a4-8356-e2ce63998504';`
`25`	`25`
`26`		`- protected static $errorNames = array(`
`27`		`- self::NOT_JSON_ERROR => 'NOT_JSON_ERROR',`
`28`		`- );`
	`26`	`+ protected static $errorNames = [`
	`27`	`+ self::INVALID_JSON_ERROR => 'INVALID_JSON_ERROR',`
	`28`	`+ ];`
`29`	`29`
`30`	`30`	`public $message = 'This value should be valid JSON.';`
`31`	`31`	`}`
Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,7 @@ public function validate($value, Constraint $constraint)`
`44`	`44`	`if (JSON_ERROR_NONE !== json_last_error()) {`
`45`	`45`	`$this->context->buildViolation($constraint->message)`
`46`	`46`	`->setParameter('{{ value }}', $this->formatValue($value))`
`47`		`- ->setCode(Json::NOT_JSON_ERROR)`
	`47`	`+ ->setCode(Json::INVALID_JSON_ERROR)`
`48`	`48`	`->addViolation();`
`49`	`49`	`}`
`50`	`50`	`}`