bug #58189 [Process] Fix backwards compatibility for invalid commands (ausi)

nicolas-grekas · nicolas-grekas · commit 15158aa3faea · 2024-09-06T11:41:09.000+02:00
This PR was squashed before being merged into the 7.1 branch. Discussion ---------- [Process] Fix backwards compatibility for invalid commands | Q | A | ------------- | --- | Branch? | 7.1 | Bug fix? | yes | New feature? | no  | Deprecations? | maybe? | Issues | Fix #57946 | License | MIT As discussed in #57946 (comment) Commits ------- e13bf4e [Process] Fix backwards compatibility for invalid commands
diff --git a/src/Symfony/Component/Process/Process.php b/src/Symfony/Component/Process/Process.php
@@ -358,6 +358,11 @@ public function start(?callable $callback = null, array $env = []): void
 
         try {
             $process = @proc_open($commandline, $descriptors, $this->processPipes->pipes, $this->cwd, $envPairs, $this->options);
+
+            // Ensure array vs string commands behave the same
+            if (!$process && \is_array($commandline)) {
+                $process = @proc_open('exec '.$this->buildShellCommandline($commandline), $descriptors, $this->processPipes->pipes, $this->cwd, $envPairs, $this->options);
+            }
         } finally {
             if ($this->ignoredSignals && \function_exists('pcntl_sigprocmask')) {
                 // we restore the signal mask here to avoid any side effects
diff --git a/src/Symfony/Component/Process/Tests/ProcessTest.php b/src/Symfony/Component/Process/Tests/ProcessTest.php
@@ -72,13 +72,8 @@ public function testInvalidCwd()
      */
     public function testInvalidCommand(Process $process)
     {
-        try {
-            $this->assertSame('\\' === \DIRECTORY_SEPARATOR ? 1 : 127, $process->run());
-        } catch (ProcessStartFailedException $e) {
-            // An invalid command might already fail during start since PHP 8.3 for platforms
-            // supporting posix_spawn(), see https://github.com/php/php-src/issues/12589
-            $this->assertStringContainsString('No such file or directory', $e->getMessage());
-        }
+        // An invalid command should not fail during start
+        $this->assertSame('\\' === \DIRECTORY_SEPARATOR ? 1 : 127, $process->run());
     }
 
     public function invalidProcessProvider()
