bug #18072 [serializer][ObjectNormalizer] fixed Undefined attributeName. (aitboudad)

fabpot · fabpot · commit 188726199be4 · 2016-03-10T16:30:15.000+01:00
This PR was merged into the 3.1-dev branch. Discussion ---------- [serializer][ObjectNormalizer] fixed Undefined attributeName. | Q | A | ------------- | --- | Branch | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ~ | License | MIT | Doc PR | ~ Commits ------- ee087a1 [serializer][ObjectNormalizer] fixed Undefined attributeName.
diff --git a/src/Symfony/Component/Serializer/Normalizer/ObjectNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/ObjectNormalizer.php
@@ -57,6 +57,7 @@ protected function extractAttributes($object, $format = null, array $context = a
             }
 
             $name = $reflMethod->name;
+            $attributeName = null;
 
             if (0 === strpos($name, 'get') || 0 === strpos($name, 'has')) {
                 // getters and hassers
@@ -66,7 +67,7 @@ protected function extractAttributes($object, $format = null, array $context = a
                 $attributeName = lcfirst(substr($name, 2));
             }
 
-            if ($this->isAllowedAttribute($object, $attributeName)) {
+            if (null !== $attributeName && $this->isAllowedAttribute($object, $attributeName)) {
                 $attributes[$attributeName] = true;
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -57,6 +57,7 @@ protected function extractAttributes($object, $format = null, array $context = a`
`57`	`57`	`}`
`58`	`58`
`59`	`59`	`$name = $reflMethod->name;`
	`60`	`+ $attributeName = null;`
`60`	`61`
`61`	`62`	`if (0 === strpos($name, 'get') \|\| 0 === strpos($name, 'has')) {`
`62`	`63`	`// getters and hassers`
`@@ -66,7 +67,7 @@ protected function extractAttributes($object, $format = null, array $context = a`
`66`	`67`	`$attributeName = lcfirst(substr($name, 2));`
`67`	`68`	`}`
`68`	`69`
`69`		`- if ($this->isAllowedAttribute($object, $attributeName)) {`
	`70`	`+ if (null !== $attributeName && $this->isAllowedAttribute($object, $attributeName)) {`
`70`	`71`	`$attributes[$attributeName] = true;`
`71`	`72`	`}`
`72`	`73`	`}`