minor #58415 [Cache][Routing] do not use TestCase::getName() when possible (xabbuh)

nicolas-grekas · nicolas-grekas · commit 199287ee1c7e · 2024-10-01T10:17:03.000+02:00
This PR was merged into the 5.4 branch. Discussion ---------- [Cache][Routing] do not use `TestCase::getName()` when possible | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT The method has been removed in PHPUnit 10. Commits ------- 9dd993c do not use TestCase::getName() when possible
diff --git a/src/Symfony/Component/Cache/Tests/Adapter/ApcuAdapterTest.php b/src/Symfony/Component/Cache/Tests/Adapter/ApcuAdapterTest.php
@@ -30,7 +30,7 @@ public function createCachePool(int $defaultLifetime = 0): CacheItemPoolInterfac
             $this->markTestSkipped('APCu extension is required.');
         }
         if ('cli' === \PHP_SAPI && !filter_var(\ini_get('apc.enable_cli'), \FILTER_VALIDATE_BOOLEAN)) {
-            if ('testWithCliSapi' !== $this->getName()) {
+            if ('testWithCliSapi' !== (method_exists($this, 'name') ? $this->name() : $this->getName())) {
                 $this->markTestSkipped('apc.enable_cli=1 is required.');
             }
         }
diff --git a/src/Symfony/Component/Routing/Tests/Generator/Dumper/CompiledUrlGeneratorDumperTest.php b/src/Symfony/Component/Routing/Tests/Generator/Dumper/CompiledUrlGeneratorDumperTest.php
@@ -52,8 +52,8 @@ protected function setUp(): void
 
         $this->routeCollection = new RouteCollection();
         $this->generatorDumper = new CompiledUrlGeneratorDumper($this->routeCollection);
-        $this->testTmpFilepath = sys_get_temp_dir().'/php_generator.'.$this->getName().'.php';
-        $this->largeTestTmpFilepath = sys_get_temp_dir().'/php_generator.'.$this->getName().'.large.php';
+        $this->testTmpFilepath = sys_get_temp_dir().'/php_generator.php';
+        $this->largeTestTmpFilepath = sys_get_temp_dir().'/php_generator.large.php';
         @unlink($this->testTmpFilepath);
         @unlink($this->largeTestTmpFilepath);
     }

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ public function createCachePool(int $defaultLifetime = 0): CacheItemPoolInterfac`
`30`	`30`	`$this->markTestSkipped('APCu extension is required.');`
`31`	`31`	`}`
`32`	`32`	`if ('cli' === \PHP_SAPI && !filter_var(\ini_get('apc.enable_cli'), \FILTER_VALIDATE_BOOLEAN)) {`
`33`		`- if ('testWithCliSapi' !== $this->getName()) {`
	`33`	`+ if ('testWithCliSapi' !== (method_exists($this, 'name') ? $this->name() : $this->getName())) {`
`34`	`34`	`$this->markTestSkipped('apc.enable_cli=1 is required.');`
`35`	`35`	`}`
`36`	`36`	`}`