bug #51328 [Messenger] Always return bool from messenger amqp connection nack (Danielss89)

fabpot · fabpot · commit 1a2eb143723b · 2023-08-11T10:16:28.000+02:00
This PR was merged into the 5.4 branch. Discussion ---------- [Messenger] Always return bool from messenger amqp connection nack | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | no | License | MIT This PR fixes the nack method return value of amqp connection. With php-amqp 2 it needs to be a boolean. Another PR fixed the ack method. Commits ------- 33f5156 Always return bool from messenger amqp conncetion nack
diff --git a/src/Symfony/Component/Messenger/Bridge/Amqp/Transport/Connection.php b/src/Symfony/Component/Messenger/Bridge/Amqp/Transport/Connection.php
@@ -461,7 +461,7 @@ public function ack(\AMQPEnvelope $message, string $queueName): bool
 
     public function nack(\AMQPEnvelope $message, string $queueName, int $flags = \AMQP_NOPARAM): bool
     {
-        return $this->queue($queueName)->nack($message->getDeliveryTag(), $flags);
+        return $this->queue($queueName)->nack($message->getDeliveryTag(), $flags) ?? true;
     }
 
     public function setup(): void

Original file line number	Diff line number	Diff line change
`@@ -461,7 +461,7 @@ public function ack(\AMQPEnvelope $message, string $queueName): bool`
`461`	`461`
`462`	`462`	`public function nack(\AMQPEnvelope $message, string $queueName, int $flags = \AMQP_NOPARAM): bool`
`463`	`463`	`{`
`464`		`- return $this->queue($queueName)->nack($message->getDeliveryTag(), $flags);`
	`464`	`+ return $this->queue($queueName)->nack($message->getDeliveryTag(), $flags) ?? true;`
`465`	`465`	`}`
`466`	`466`
`467`	`467`	`public function setup(): void`