bug #49581 Avoid leading .. for temporary files from Filesystem recursive remove (giosh94mhz)

nicolas-grekas · nicolas-grekas · commit 1a5e19b12795 · 2023-04-17T12:27:53.000+02:00
This PR was merged into the 5.4 branch. Discussion ---------- Avoid leading .. for temporary files from Filesystem recursive remove | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | Method `Filesystem::doRemove` is using renaming of parent directory before recursive removal, in order to implement atomic remove. This is a good thing, but to implement this is generating a random path name, with a modified base64 which replaces base64's `=` sign with `.`. This may lead to directory named as `path/..8U6/` which freaked out our synchronization tools and security log scanner. Since the leading `.` is already (correctly) hard-coded, I see no issue in using `_` as a safer alternative. Commits ------- 2dd8183 Avoid leading .. for temporary files from Filesystem recursive remove
diff --git a/src/Symfony/Component/Filesystem/Filesystem.php b/src/Symfony/Component/Filesystem/Filesystem.php
@@ -170,7 +170,7 @@ private static function doRemove(array $files, bool $isRecursive): void
                 }
             } elseif (is_dir($file)) {
                 if (!$isRecursive) {
-                    $tmpName = \dirname(realpath($file)).'/.'.strrev(strtr(base64_encode(random_bytes(2)), '/=', '-.'));
+                    $tmpName = \dirname(realpath($file)).'/.'.strrev(strtr(base64_encode(random_bytes(2)), '/=', '-_'));
 
                     if (file_exists($tmpName)) {
                         try {

Original file line number	Diff line number	Diff line change
`@@ -170,7 +170,7 @@ private static function doRemove(array $files, bool $isRecursive): void`
`170`	`170`	`}`
`171`	`171`	`} elseif (is_dir($file)) {`
`172`	`172`	`if (!$isRecursive) {`
`173`		`- $tmpName = \dirname(realpath($file)).'/.'.strrev(strtr(base64_encode(random_bytes(2)), '/=', '-.'));`
	`173`	`+ $tmpName = \dirname(realpath($file)).'/.'.strrev(strtr(base64_encode(random_bytes(2)), '/=', '-_'));`
`174`	`174`
`175`	`175`	`if (file_exists($tmpName)) {`
`176`	`176`	`try {`