Provide possible fix to allow new in initializers

agustingomes · agustingomes · commit 1a728dd1080e · 2021-09-30T23:58:09.000+02:00
It implements a new private method to go through all the possible
scenarios of a parameter to avoid casting objects to string that
potentially won't implement Serializable interface.
diff --git a/src/Symfony/Component/Config/Resource/ReflectionClassResource.php b/src/Symfony/Component/Config/Resource/ReflectionClassResource.php
@@ -199,39 +199,35 @@ private function generateSignature(\ReflectionClass $class): iterable
                 $parametersWithUndefinedConstants[$p->name] = true;
             }
 
-            if (!$parametersWithUndefinedConstants) {
-                yield preg_replace('/^  @@.*/m', '', $m);
-            } else {
-                $t = $m->getReturnType();
-                $stack = [
-                    $m->getDocComment(),
-                    $m->getName(),
-                    $m->isAbstract(),
-                    $m->isFinal(),
-                    $m->isStatic(),
-                    $m->isPublic(),
-                    $m->isPrivate(),
-                    $m->isProtected(),
-                    $m->returnsReference(),
-                    $t instanceof \ReflectionNamedType ? ((string) $t->allowsNull()).$t->getName() : (string) $t,
-                ];
-
-                foreach ($m->getParameters() as $p) {
-                    if (!isset($parametersWithUndefinedConstants[$p->name])) {
-                        $stack[] = (string) $p;
-                    } else {
-                        $t = $p->getType();
-                        $stack[] = $p->isOptional();
-                        $stack[] = $t instanceof \ReflectionNamedType ? ((string) $t->allowsNull()).$t->getName() : (string) $t;
-                        $stack[] = $p->isPassedByReference();
-                        $stack[] = $p->isVariadic();
-                        $stack[] = $p->getName();
-                    }
-                }
+            $t = $m->getReturnType();
+            $stack = [
+                $m->getDocComment(),
+                $m->getName(),
+                $m->isAbstract(),
+                $m->isFinal(),
+                $m->isStatic(),
+                $m->isPublic(),
+                $m->isPrivate(),
+                $m->isProtected(),
+                $m->returnsReference(),
+                $t instanceof \ReflectionNamedType ? ((string) $t->allowsNull()).$t->getName() : (string) $t,
+            ];
 
-                yield implode(',', $stack);
+            foreach ($m->getParameters() as $p) {
+                if (!isset($parametersWithUndefinedConstants[$p->name])) {
+                    $stack[] = $this->extractParameterData($p);
+                } else {
+                    $t = $p->getType();
+                    $stack[] = $p->isOptional();
+                    $stack[] = $t instanceof \ReflectionNamedType ? ((string) $t->allowsNull()).$t->getName() : (string) $t;
+                    $stack[] = $p->isPassedByReference();
+                    $stack[] = $p->isVariadic();
+                    $stack[] = $p->getName();
+                }
             }
 
+            yield implode(',', $stack);
+
             yield print_r($defaults, true);
         }
 
@@ -259,4 +255,34 @@ private function generateSignature(\ReflectionClass $class): iterable
             yield print_r($class->name::getSubscribedServices(), true);
         }
     }
+
+    private function extractParameterData(\ReflectionParameter $p): string
+    {
+        if (false === $p->isOptional()) {
+            return (string) $p;
+        }
+
+        if (false === $p->isDefaultValueAvailable()) {
+            return (string) $p;
+        }
+
+        $defaultValue = $p->getDefaultValue();
+        if (false === \is_object($defaultValue)) {
+            return (string) $p;
+        }
+
+        $class = \get_class($defaultValue);
+        $type = $p->getType();
+
+        if (null === $type) {
+            return 'untyped = '.$class;
+        }
+
+        $typeName = (string) $type;
+        if ($type instanceof \ReflectionNamedType) {
+            $typeName = $type->getName();
+        }
+
+        return $typeName.' = '.$class;
+    }
 }
