bug #29992 [DependencyInjection] fix DOM element namespace URL access (xabbuh)

nicolas-grekas · nicolas-grekas · commit 1aa652e2cbbd · 2019-01-26T21:58:56.000+01:00
This PR was merged into the 4.3-dev branch. Discussion ---------- [DependencyInjection] fix DOM element namespace URL access | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- 429bddf fix DOM element namespace URL access
diff --git a/src/Symfony/Component/DependencyInjection/Loader/XmlFileLoader.php b/src/Symfony/Component/DependencyInjection/Loader/XmlFileLoader.php
@@ -672,7 +672,7 @@ private function validateAlias(\DOMElement $alias, $file)
         }
 
         foreach ($alias->childNodes as $child) {
-            if (!$child instanceof \DOMElement && self::NS !== $child->namespaceURI) {
+            if (!$child instanceof \DOMElement || self::NS !== $child->namespaceURI) {
                 continue;
             }
             if (!\in_array($child->localName, ['deprecated'], true)) {

Original file line number	Diff line number	Diff line change
`@@ -672,7 +672,7 @@ private function validateAlias(\DOMElement $alias, $file)`
`672`	`672`	`}`
`673`	`673`
`674`	`674`	`foreach ($alias->childNodes as $child) {`
`675`		`- if (!$child instanceof \DOMElement && self::NS !== $child->namespaceURI) {`
	`675`	`+ if (!$child instanceof \DOMElement \|\| self::NS !== $child->namespaceURI) {`
`676`	`676`	`continue;`
`677`	`677`	`}`
`678`	`678`	`if (!\in_array($child->localName, ['deprecated'], true)) {`