Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 1d13744

Browse files
author
Adam Szaraniec
committed
Support for parsing PHP constants in yaml loader
1 parent 9d24e80 commit 1d13744

File tree

5 files changed

+83
-61
lines changed

5 files changed

+83
-61
lines changed

‎src/Symfony/Component/Validator/CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ CHANGELOG
1818
-----
1919

2020
* deprecated `Tests\Constraints\AbstractContraintValidatorTest` in favor of `Test\ConstraintValidatorTestCase`
21+
* added support for PHP constants in YAML configuration files
2122

2223
3.1.0
2324
-----

‎src/Symfony/Component/Validator/Mapping/Loader/YamlFileLoader.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ protected function parseNodes(array $nodes)
116116
private function parseFile($path)
117117
{
118118
try {
119-
$classes = $this->yamlParser->parse(file_get_contents($path), Yaml::PARSE_KEYS_AS_STRINGS);
119+
$classes = $this->yamlParser->parse(file_get_contents($path), Yaml::PARSE_KEYS_AS_STRINGS|Yaml::PARSE_CONSTANT);
120120
} catch (ParseException $e) {
121121
throw new \InvalidArgumentException(sprintf('The file "%s" does not contain valid YAML.', $path), 0, $e);
122122
}

‎src/Symfony/Component/Validator/Tests/Mapping/Loader/YamlFileLoaderTest.php

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -124,6 +124,19 @@ public function testLoadClassMetadata()
124124
$this->assertEquals($expected, $metadata);
125125
}
126126

127+
public function testLoadClassMetadataWithConstants()
128+
{
129+
$loader = new YamlFileLoader(__DIR__.'/mapping-with-constants.yml');
130+
$metadata = new ClassMetadata('Symfony\Component\Validator\Tests\Fixtures\Entity');
131+
132+
$loader->loadClassMetadata($metadata);
133+
134+
$expected = new ClassMetadata('Symfony\Component\Validator\Tests\Fixtures\Entity');
135+
$expected->addPropertyConstraint('firstName', new Range(array('max' => PHP_INT_MAX)));
136+
137+
$this->assertEquals($expected, $metadata);
138+
}
139+
127140
public function testLoadGroupSequenceProvider()
128141
{
129142
$loader = new YamlFileLoader(__DIR__.'/constraint-mapping.yml');

‎src/Symfony/Component/Validator/Tests/Mapping/Loader/mapping-with-constants.yml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
namespaces:
2+
custom: Symfony\Component\Validator\Tests\Fixtures\
3+
4+
Symfony\Component\Validator\Tests\Fixtures\Entity:
5+
properties:
6+
firstName:
7+
- Range:
8+
max: !php/const:PHP_INT_MAX

‎src/Symfony/Component/Validator/composer.json

Lines changed: 60 additions & 60 deletions
Original file line numberDiff line numberDiff line change
@@ -1,64 +1,64 @@
11
{
2-
"name": "symfony/validator",
3-
"type": "library",
4-
"description": "Symfony Validator Component",
5-
"keywords": [],
6-
"homepage": "https://symfony.com",
7-
"license": "MIT",
8-
"authors": [
9-
{
10-
"name": "Fabien Potencier",
11-
"email": "[email protected]"
12-
},
13-
{
14-
"name": "Symfony Community",
15-
"homepage": "https://symfony.com/contributors"
16-
}
17-
],
18-
"require": {
19-
"php": ">=5.5.9",
20-
"symfony/polyfill-mbstring": "~1.0",
21-
"symfony/translation": "~2.8|~3.0|~4.0"
2+
"name": "symfony/validator",
3+
"type": "library",
4+
"description": "Symfony Validator Component",
5+
"keywords": [],
6+
"homepage": "https://symfony.com",
7+
"license": "MIT",
8+
"authors": [
9+
{
10+
"name": "Fabien Potencier",
11+
"email": "[email protected]"
2212
},
23-
"require-dev": {
24-
"symfony/http-foundation": "~2.8|~3.0|~4.0",
25-
"symfony/intl": "^2.8.18|^3.2.5|~4.0",
26-
"symfony/yaml": "~3.3|~4.0",
27-
"symfony/config": "~2.8|~3.0|~4.0",
28-
"symfony/dependency-injection": "~3.3|~4.0",
29-
"symfony/expression-language": "~2.8|~3.0|~4.0",
30-
"symfony/cache": "~3.1|~4.0",
31-
"doctrine/annotations": "~1.0",
32-
"doctrine/cache": "~1.0",
33-
"egulias/email-validator": "^1.2.8|~2.0"
34-
},
35-
"conflict": {
36-
"phpunit/phpunit": "<4.8.35|<5.4.3,>=5.0",
37-
"symfony/dependency-injection": "<3.3",
38-
"symfony/yaml": "<3.3"
39-
},
40-
"suggest": {
41-
"psr/cache-implementation": "For using the metadata cache.",
42-
"doctrine/annotations": "For using the annotation mapping. You will also need doctrine/cache.",
43-
"doctrine/cache": "For using the default cached annotation reader and metadata cache.",
44-
"symfony/http-foundation": "",
45-
"symfony/intl": "",
46-
"symfony/yaml": "",
47-
"symfony/config": "",
48-
"egulias/email-validator": "Strict (RFC compliant) email validation",
49-
"symfony/property-access": "For using the Expression validator",
50-
"symfony/expression-language": "For using the Expression validator"
51-
},
52-
"autoload": {
53-
"psr-4": { "Symfony\\Component\\Validator\\": "" },
54-
"exclude-from-classmap": [
55-
"/Tests/"
56-
]
57-
},
58-
"minimum-stability": "dev",
59-
"extra": {
60-
"branch-alias": {
61-
"dev-master": "3.4-dev"
62-
}
13+
{
14+
"name": "Symfony Community",
15+
"homepage": "https://symfony.com/contributors"
16+
}
17+
],
18+
"require": {
19+
"php": ">=5.5.9",
20+
"symfony/polyfill-mbstring": "~1.0",
21+
"symfony/translation": "~2.8|~3.0|~4.0"
22+
},
23+
"require-dev": {
24+
"symfony/http-foundation": "~2.8|~3.0|~4.0",
25+
"symfony/intl": "^2.8.18|^3.2.5|~4.0",
26+
"symfony/yaml": "~3.3|~4.0",
27+
"symfony/config": "~2.8|~3.0|~4.0",
28+
"symfony/dependency-injection": "~3.3|~4.0",
29+
"symfony/expression-language": "~2.8|~3.0|~4.0",
30+
"symfony/cache": "~3.1|~4.0",
31+
"doctrine/annotations": "~1.0",
32+
"doctrine/cache": "~1.0",
33+
"egulias/email-validator": "^1.2.8|~2.0"
34+
},
35+
"conflict": {
36+
"phpunit/phpunit": "<4.8.35|<5.4.3,>=5.0",
37+
"symfony/dependency-injection": "<3.3",
38+
"symfony/yaml": "<3.3"
39+
},
40+
"suggest": {
41+
"psr/cache-implementation": "For using the metadata cache.",
42+
"doctrine/annotations": "For using the annotation mapping. You will also need doctrine/cache.",
43+
"doctrine/cache": "For using the default cached annotation reader and metadata cache.",
44+
"symfony/http-foundation": "",
45+
"symfony/intl": "",
46+
"symfony/yaml": "",
47+
"symfony/config": "",
48+
"egulias/email-validator": "Strict (RFC compliant) email validation",
49+
"symfony/property-access": "For using the Expression validator",
50+
"symfony/expression-language": "For using the Expression validator"
51+
},
52+
"autoload": {
53+
"psr-4": { "Symfony\\Component\\Validator\\": "" },
54+
"exclude-from-classmap": [
55+
"/Tests/"
56+
]
57+
},
58+
"minimum-stability": "dev",
59+
"extra": {
60+
"branch-alias": {
61+
"dev-master": "3.4-dev"
6362
}
63+
}
6464
}

0 commit comments

Comments
 (0)