Code cleanup

Ruben Jacobs · rjwebdev · commit 1d542bd44f0e · 2019-07-20T18:39:54.000+02:00
diff --git a/src/Symfony/Component/HttpClient/Response/CurlResponse.php b/src/Symfony/Component/HttpClient/Response/CurlResponse.php
@@ -287,7 +287,7 @@ private static function parseHeaderLine($ch, string $data, array &$info, array &
             // Regular header line: add it to the list
 
             self::addResponseHeaders([substr($data, 0, -2)], $info, $headers);
-            if (isset($headers['content-type'], $options['buffer']) && is_string($options['buffer'])) {
+            if (isset($headers['content-type'], $options['buffer']) && \is_string($options['buffer'])) {
                 self::handleContentType($content, $headers['content-type'][0], $options['buffer']);
             }
 
diff --git a/src/Symfony/Component/HttpClient/Response/NativeResponse.php b/src/Symfony/Component/HttpClient/Response/NativeResponse.php
@@ -52,7 +52,7 @@ public function __construct(NativeClientState $multi, $context, string $url, $op
         $this->resolveRedirect = $resolveRedirect;
         $this->onProgress = $onProgress;
         $this->content = $options['buffer'] ? fopen('php://temp', 'w+') : null;
-        $this->bufferRegex = isset($options['buffer']) && is_string($options['buffer']) ? $options['buffer'] : null;
+        $this->bufferRegex = isset($options['buffer']) && \is_string($options['buffer']) ? $options['buffer'] : null;
 
         // Temporary resources to dechunk/inflate the response stream
         $this->buffer = fopen('php://temp', 'w+');
diff --git a/src/Symfony/Component/HttpClient/Tests/CurlHttpClientTest.php b/src/Symfony/Component/HttpClient/Tests/CurlHttpClientTest.php
@@ -13,8 +13,6 @@
 
 use Psr\Log\AbstractLogger;
 use Symfony\Component\HttpClient\CurlHttpClient;
-use Symfony\Component\HttpClient\MockHttpClient;
-use Symfony\Component\HttpClient\Response\MockResponse;
 use Symfony\Contracts\HttpClient\HttpClientInterface;
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -287,7 +287,7 @@ private static function parseHeaderLine($ch, string $data, array &$info, array &`
`287`	`287`	`// Regular header line: add it to the list`
`288`	`288`
`289`	`289`	`self::addResponseHeaders([substr($data, 0, -2)], $info, $headers);`
`290`		`- if (isset($headers['content-type'], $options['buffer']) && is_string($options['buffer'])) {`
	`290`	`+ if (isset($headers['content-type'], $options['buffer']) && \is_string($options['buffer'])) {`
`291`	`291`	`self::handleContentType($content, $headers['content-type'][0], $options['buffer']);`
`292`	`292`	`}`
`293`	`293`