Feat: Add missing DROP_NEW_LINE flag to support empty lines in CSV

fnogatz · fnogatz · commit 1dd8bba1d154 · 2026-01-12T19:28:58.000+01:00
diff --git a/src/Symfony/Component/Translation/Loader/CsvFileLoader.php b/src/Symfony/Component/Translation/Loader/CsvFileLoader.php
@@ -33,7 +33,7 @@ protected function loadResource(string $resource): array
             throw new NotFoundResourceException(\sprintf('Error opening file "%s".', $resource), 0, $e);
         }
 
-        $file->setFlags(\SplFileObject::READ_CSV | \SplFileObject::SKIP_EMPTY);
+        $file->setFlags(\SplFileObject::READ_CSV | \SplFileObject::SKIP_EMPTY | \SplFileObject::DROP_NEW_LINE);
         $file->setCsvControl($this->delimiter, $this->enclosure, '');
 
         foreach ($file as $data) {

Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ protected function loadResource(string $resource): array`
`33`	`33`	`throw new NotFoundResourceException(\sprintf('Error opening file "%s".', $resource), 0, $e);`
`34`	`34`	`}`
`35`	`35`
`36`		`- $file->setFlags(\SplFileObject::READ_CSV \| \SplFileObject::SKIP_EMPTY);`
	`36`	`+ $file->setFlags(\SplFileObject::READ_CSV \| \SplFileObject::SKIP_EMPTY \| \SplFileObject::DROP_NEW_LINE);`
`37`	`37`	`$file->setCsvControl($this->delimiter, $this->enclosure, '');`
`38`	`38`
`39`	`39`	`foreach ($file as $data) {`