[HttpClient] Disable HTTP/2 PUSH by default when using curl

nicolas-grekas · nicolas-grekas · commit 1f3413313cd7 · 2024-07-29T14:56:13.000+02:00
diff --git a/src/Symfony/Component/HttpClient/CurlHttpClient.php b/src/Symfony/Component/HttpClient/CurlHttpClient.php
@@ -67,7 +67,7 @@ final class CurlHttpClient implements HttpClientInterface, LoggerAwareInterface,
      *
      * @see HttpClientInterface::OPTIONS_DEFAULTS for available options
      */
-    public function __construct(array $defaultOptions = [], int $maxHostConnections = 6, int $maxPendingPushes = 50)
+    public function __construct(array $defaultOptions = [], int $maxHostConnections = 6, int $maxPendingPushes = 0)
     {
         if (!\extension_loaded('curl')) {
             throw new \LogicException('You cannot use the "Symfony\Component\HttpClient\CurlHttpClient" as the "curl" extension is not installed.');
diff --git a/src/Symfony/Component/HttpClient/Tests/CurlHttpClientTest.php b/src/Symfony/Component/HttpClient/Tests/CurlHttpClientTest.php
@@ -32,6 +32,10 @@ protected function getHttpClient(string $testCase): HttpClientInterface
             }
         }
 
+        if (str_contains($testCase, 'Push')) {
+            return new CurlHttpClient(['verify_peer' => false, 'verify_host' => false], 6, 50);
+        }
+
         return new CurlHttpClient(['verify_peer' => false, 'verify_host' => false]);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@ final class CurlHttpClient implements HttpClientInterface, LoggerAwareInterface,`
`67`	`67`	`*`
`68`	`68`	`* @see HttpClientInterface::OPTIONS_DEFAULTS for available options`
`69`	`69`	`*/`
`70`		`- public function __construct(array $defaultOptions = [], int $maxHostConnections = 6, int $maxPendingPushes = 50)`
	`70`	`+ public function __construct(array $defaultOptions = [], int $maxHostConnections = 6, int $maxPendingPushes = 0)`
`71`	`71`	`{`
`72`	`72`	`if (!\extension_loaded('curl')) {`
`73`	`73`	`throw new \LogicException('You cannot use the "Symfony\Component\HttpClient\CurlHttpClient" as the "curl" extension is not installed.');`
Original file line number	Diff line number	Diff line change
`@@ -32,6 +32,10 @@ protected function getHttpClient(string $testCase): HttpClientInterface`
`32`	`32`	`}`
`33`	`33`	`}`
`34`	`34`
	`35`	`+ if (str_contains($testCase, 'Push')) {`
	`36`	`+ return new CurlHttpClient(['verify_peer' => false, 'verify_host' => false], 6, 50);`
	`37`	`+ }`
	`38`	`+`
`35`	`39`	`return new CurlHttpClient(['verify_peer' => false, 'verify_host' => false]);`
`36`	`40`	`}`
`37`	`41`