add a test to verify setMaxSteps, fix format not recalculated

ostrolucky · ostrolucky · commit 206f3c9e8ddc · 2018-03-13T22:58:56.000+01:00
diff --git a/src/Symfony/Component/Console/Helper/ProgressBar.php b/src/Symfony/Component/Console/Helper/ProgressBar.php
@@ -364,6 +364,7 @@ private function setRealFormat(string $format)
 
     public function setMaxSteps(int $max)
     {
+        $this->format = null;
         $this->max = max(0, $max);
         $this->stepWidth = $this->max ? Helper::strlen((string) $this->max) : 4;
     }
diff --git a/src/Symfony/Component/Console/Tests/Helper/ProgressBarTest.php b/src/Symfony/Component/Console/Tests/Helper/ProgressBarTest.php
@@ -592,6 +592,29 @@ public function testWithoutMax()
         );
     }
 
+    public function testSettingMaxStepsDuringProgressing()
+    {
+        $output = $this->getOutputStream();
+        $bar = new ProgressBar($output);
+        $bar->start();
+        $bar->setProgress(2);
+        $bar->setMaxSteps(10);
+        $bar->setProgress(5);
+        $bar->setMaxSteps(100);
+        $bar->setProgress(10);
+        $bar->finish();
+
+        rewind($output->getStream());
+        $this->assertEquals(
+            rtrim('    0 [>---------------------------]').
+            rtrim($this->generateOutput('    2 [-->-------------------------]')).
+            rtrim($this->generateOutput('  5/10 [==============>-------------]  50%')).
+            rtrim($this->generateOutput('  10/100 [==>-------------------------]  10%')).
+            rtrim($this->generateOutput(' 100/100 [============================] 100%')),
+            stream_get_contents($output->getStream())
+        );
+    }
+
     public function testWithSmallScreen()
     {
         $output = $this->getOutputStream();

Original file line number	Diff line number	Diff line change
`@@ -364,6 +364,7 @@ private function setRealFormat(string $format)`
`364`	`364`
`365`	`365`	`public function setMaxSteps(int $max)`
`366`	`366`	`{`
	`367`	`+ $this->format = null;`
`367`	`368`	`$this->max = max(0, $max);`
`368`	`369`	`$this->stepWidth = $this->max ? Helper::strlen((string) $this->max) : 4;`
`369`	`370`	`}`