improved message when alias service is not found

xabbuh · xabbuh · commit 23b5b25dbd85 · 2018-09-11T18:52:50.000+02:00
When using the YAML config format, it can be confusing that you need to prefix the aliased service id with an `@` character when passing it as a string, but that you have to omit it when using the `alias` attribute: ```yaml foo: '@app\Foo' foo: alias: 'App\Foo' ``` This commit will enhance the generated error message in cases where the aliased service id is prefixed with the `@` character in the `alias` option like this: ```yaml foo: alias: '@app\Foo' ```
diff --git a/src/Symfony/Component/DependencyInjection/Compiler/ReplaceAliasByActualDefinitionPass.php b/src/Symfony/Component/DependencyInjection/Compiler/ReplaceAliasByActualDefinitionPass.php
@@ -58,7 +58,13 @@ public function process(ContainerBuilder $container)
             try {
                 $definition = $container->getDefinition($targetId);
             } catch (InvalidArgumentException $e) {
-                throw new InvalidArgumentException(sprintf('Unable to replace alias "%s" with actual definition "%s".', $definitionId, $targetId), null, $e);
+                $message = sprintf('Unable to replace alias "%s" with actual definition "%s".', $definitionId, $targetId);
+
+                if ('' !== $targetId && '@' === $targetId[0]) {
+                    $message .= sprintf(' Did you mean "%s"?', substr($targetId, 1));
+                }
+
+                throw new InvalidArgumentException($message, null, $e);
             }
             if ($definition->isPublic()) {
                 continue;
