[DI] fix copying expression providers when analyzing the service graph

nicolas-grekas · nicolas-grekas · commit 246164f74834 · 2018-11-25T12:18:11.000+01:00
diff --git a/src/Symfony/Component/DependencyInjection/Compiler/InlineServiceDefinitionsPass.php b/src/Symfony/Component/DependencyInjection/Compiler/InlineServiceDefinitionsPass.php
@@ -53,6 +53,9 @@ public function process(ContainerBuilder $container)
             $analyzedContainer = new ContainerBuilder();
             $analyzedContainer->setAliases($container->getAliases());
             $analyzedContainer->setDefinitions($container->getDefinitions());
+            foreach ($container->getExpressionLanguageProviders() as $provider) {
+                $analyzedContainer->addExpressionLanguageProvider($provider);
+            }
         } else {
             $analyzedContainer = $container;
         }
diff --git a/src/Symfony/Component/DependencyInjection/Tests/Compiler/CustomExpressionLanguageFunctionTest.php b/src/Symfony/Component/DependencyInjection/Tests/Compiler/CustomExpressionLanguageFunctionTest.php
@@ -0,0 +1,36 @@
+<?php
+
+namespace Symfony\Component\DependencyInjection\Tests\Compiler;
+
+use PHPUnit\Framework\TestCase;
+use Symfony\Component\DependencyInjection\ContainerBuilder;
+use Symfony\Component\DependencyInjection\Dumper\PhpDumper;
+use Symfony\Component\ExpressionLanguage\Expression;
+use Symfony\Component\ExpressionLanguage\ExpressionFunction;
+use Symfony\Component\ExpressionLanguage\ExpressionFunctionProviderInterface;
+
+class CustomExpressionLanguageFunctionTest extends TestCase
+{
+    public function testDump()
+    {
+        $container = new ContainerBuilder();
+        $container->register('test', 'stdClass')
+            ->setPublic(true)
+            ->setArguments(array(new Expression('custom_func("foobar")')));
+
+        $container->addExpressionLanguageProvider(new class() implements ExpressionFunctionProviderInterface {
+            public function getFunctions()
+            {
+                return array(
+                    ExpressionFunction::fromPhp('strtolower', 'custom_func'),
+                );
+            }
+        });
+        $container->compile();
+
+        $dump = new PhpDumper($container);
+        $dumped = $dump->dump();
+
+        $this->assertContains('strtolower("foobar")', $dumped);
+    }
+}
