[PropertyAccess] Deprecate null as allowed value for defaultLifetime argument of createCache method

jschaedl · jschaedl · commit 24f5bf0ded0d · 2019-06-28T08:03:02.000+02:00
diff --git a/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php b/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
@@ -1865,7 +1865,7 @@ private function registerCacheConfiguration(array $config, ContainerBuilder $con
 
             if (!$container->getParameter('kernel.debug')) {
                 $propertyAccessDefinition->setFactory([PropertyAccessor::class, 'createCache']);
-                $propertyAccessDefinition->setArguments([null, null, $version, new Reference('logger', ContainerInterface::IGNORE_ON_INVALID_REFERENCE)]);
+                $propertyAccessDefinition->setArguments([null, 0, $version, new Reference('logger', ContainerInterface::IGNORE_ON_INVALID_REFERENCE)]);
                 $propertyAccessDefinition->addTag('cache.pool', ['clearer' => 'cache.system_clearer']);
                 $propertyAccessDefinition->addTag('monolog.logger', ['channel' => 'cache']);
             } else {
diff --git a/src/Symfony/Component/PropertyAccess/PropertyAccessor.php b/src/Symfony/Component/PropertyAccess/PropertyAccessor.php
@@ -828,6 +828,10 @@ private function getPropertyPath($propertyPath): PropertyPath
      */
     public static function createCache($namespace, $defaultLifetime, $version, LoggerInterface $logger = null)
     {
+        if (null === $defaultLifetime) {
+            @trigger_error(sprintf('Passing null as "$defaultLifetime" 2nd argument of the "%s()" method is deprecated since Symfony 4.4, pass an integer instead.', __METHOD__), E_USER_DEPRECATED);
+        }
+
         if (!class_exists('Symfony\Component\Cache\Adapter\ApcuAdapter')) {
             throw new \LogicException(sprintf('The Symfony Cache component must be installed to use %s().', __METHOD__));
         }

Original file line number	Diff line number	Diff line change
`@@ -828,6 +828,10 @@ private function getPropertyPath($propertyPath): PropertyPath`
`828`	`828`	`*/`
`829`	`829`	`public static function createCache($namespace, $defaultLifetime, $version, LoggerInterface $logger = null)`
`830`	`830`	`{`
	`831`	`+ if (null === $defaultLifetime) {`
	`832`	`+ @trigger_error(sprintf('Passing null as "$defaultLifetime" 2nd argument of the "%s()" method is deprecated since Symfony 4.4, pass an integer instead.', __METHOD__), E_USER_DEPRECATED);`
	`833`	`+ }`
	`834`	`+`
`831`	`835`	`if (!class_exists('Symfony\Component\Cache\Adapter\ApcuAdapter')) {`
`832`	`836`	`throw new \LogicException(sprintf('The Symfony Cache component must be installed to use %s().', __METHOD__));`
`833`	`837`	`}`