Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 2557a40

Browse files
nicolas-grekasnicolas-grekas
committed
minor #41295 Remove constraint for PHP < 8 (jderusse)
This PR was squashed before being merged into the 6.0 branch. Discussion ---------- Remove constraint for PHP < 8 | Q | A | ------------- | --- | Branch? | 6.0 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Remove code check against PHP_VERSION < 8 (except for PHPUnit Bridge) Commits ------- a8c74ae Remove constraint for PHP < 8
2 parents 264c648 + a8c74ae commit 2557a40

File tree

200 files changed

+283
-1465
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

200 files changed

+283
-1465
lines changed

‎phpunit

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,9 @@ if (!file_exists(__DIR__.'/vendor/symfony/phpunit-bridge/bin/simple-phpunit')) {
88
exit(1);
99
}
1010
if (!getenv('SYMFONY_PHPUNIT_VERSION')) {
11-
if (\PHP_VERSION_ID < 70300) {
12-
putenv('SYMFONY_PHPUNIT_VERSION=8.5');
13-
} else {
14-
putenv('SYMFONY_PHPUNIT_VERSION=9.5');
15-
}
11+
putenv('SYMFONY_PHPUNIT_VERSION=9.5');
1612
}
17-
if (!getenv('SYMFONY_PATCH_TYPE_DECLARATIONS') && \PHP_VERSION_ID >= 70300) {
13+
if (!getenv('SYMFONY_PATCH_TYPE_DECLARATIONS')) {
1814
putenv('SYMFONY_PATCH_TYPE_DECLARATIONS=deprecations=1');
1915
}
2016
if (getcwd() === realpath(__DIR__.'/src/Symfony/Bridge/PhpUnit')) {

‎src/Symfony/Bridge/Doctrine/Tests/Validator/Constraints/UniqueEntityTest.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,6 @@
1616
use Symfony\Component\Validator\Mapping\ClassMetadata;
1717
use Symfony\Component\Validator\Mapping\Loader\AnnotationLoader;
1818

19-
/**
20-
* @requires PHP 8
21-
*/
2219
class UniqueEntityTest extends TestCase
2320
{
2421
public function testAttributeWithDefaultProperty()

‎src/Symfony/Bridge/Doctrine/Tests/Validator/Constraints/UniqueEntityValidatorTest.php

Lines changed: 5 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -193,9 +193,7 @@ public function provideUniquenessConstraints(): iterable
193193
'em' => self::EM_NAME,
194194
])];
195195

196-
if (\PHP_VERSION_ID >= 80000) {
197-
yield 'Named arguments' => [eval('return new \Symfony\Bridge\Doctrine\Validator\Constraints\UniqueEntity(message: "myMessage", fields: ["name"], em: "foo");')];
198-
}
196+
yield 'Named arguments' => [new UniqueEntity(message: 'myMessage', fields: ['name'], em: 'foo')];
199197
}
200198

201199
/**
@@ -229,9 +227,7 @@ public function provideConstraintsWithCustomErrorPath(): iterable
229227
'errorPath' => 'bar',
230228
])];
231229

232-
if (\PHP_VERSION_ID >= 80000) {
233-
yield 'Named arguments' => [eval('return new \Symfony\Bridge\Doctrine\Validator\Constraints\UniqueEntity(message: "myMessage", fields: ["name"], em: "foo", errorPath: "bar");')];
234-
}
230+
yield 'Named arguments' => [new UniqueEntity(message: 'myMessage', fields: ['name'], em: 'foo', errorPath: 'bar')];
235231
}
236232

237233
/**
@@ -290,9 +286,7 @@ public function provideConstraintsWithIgnoreNullDisabled(): iterable
290286
'ignoreNull' => false,
291287
])];
292288

293-
if (\PHP_VERSION_ID >= 80000) {
294-
yield 'Named arguments' => [eval('return new \Symfony\Bridge\Doctrine\Validator\Constraints\UniqueEntity(message: "myMessage", fields: ["name", "name2"], em: "foo", ignoreNull: false);')];
295-
}
289+
yield 'Named arguments' => [new UniqueEntity(message: 'myMessage', fields: ['name', 'name2'], em: 'foo', ignoreNull: false)];
296290
}
297291

298292
/**
@@ -339,9 +333,7 @@ public function provideConstraintsWithIgnoreNullEnabled(): iterable
339333
'ignoreNull' => true,
340334
])];
341335

342-
if (\PHP_VERSION_ID >= 80000) {
343-
yield 'Named arguments' => [eval('return new \Symfony\Bridge\Doctrine\Validator\Constraints\UniqueEntity(message: "myMessage", fields: ["name", "name2"], em: "foo", ignoreNull: true);')];
344-
}
336+
yield 'Named arguments' => [new UniqueEntity(message: 'myMessage', fields: ['name', 'name2'], em: 'foo', ignoreNull: true)];
345337
}
346338

347339
public function testValidateUniquenessWithValidCustomErrorPath()
@@ -440,9 +432,7 @@ public function provideConstraintsWithCustomRepositoryMethod(): iterable
440432
'repositoryMethod' => 'findByCustom',
441433
])];
442434

443-
if (\PHP_VERSION_ID >= 80000) {
444-
yield 'Named arguments' => [eval('return new \Symfony\Bridge\Doctrine\Validator\Constraints\UniqueEntity(message: "myMessage", fields: ["name"], em: "foo", repositoryMethod: "findByCustom");')];
445-
}
435+
yield 'Named arguments' => [new UniqueEntity(message: 'myMessage', fields: ['name'], em: 'foo', repositoryMethod: 'findByCustom')];
446436
}
447437

448438
/**

‎src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1016,10 +1016,6 @@ private function registerRouterConfiguration(array $config, ContainerBuilder $co
10161016
->replaceArgument(0, $config['default_uri']);
10171017
}
10181018

1019-
if (\PHP_VERSION_ID < 80000 && !$this->annotationsConfigEnabled) {
1020-
return;
1021-
}
1022-
10231019
$container->register('routing.loader.annotation', AnnotatedRouteControllerLoader::class)
10241020
->setPublic(false)
10251021
->addTag('routing.loader', ['priority' => -10])

‎src/Symfony/Component/Cache/Adapter/FilesystemTagAwareAdapter.php

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ protected function doDeleteYieldTags(array $ids): iterable
140140
continue;
141141
}
142142

143-
if ((\PHP_VERSION_ID >= 70300 || '\\' !== \DIRECTORY_SEPARATOR) && !@unlink($file)) {
143+
if (!@unlink($file)) {
144144
fclose($h);
145145
continue;
146146
}
@@ -165,10 +165,6 @@ protected function doDeleteYieldTags(array $ids): iterable
165165
}
166166

167167
fclose($h);
168-
169-
if (\PHP_VERSION_ID < 70300 && '\\' === \DIRECTORY_SEPARATOR) {
170-
@unlink($file);
171-
}
172168
}
173169
}
174170

‎src/Symfony/Component/Cache/Marshaller/DefaultMarshaller.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,9 @@ class DefaultMarshaller implements MarshallerInterface
2525
public function __construct(bool $useIgbinarySerialize = null)
2626
{
2727
if (null === $useIgbinarySerialize) {
28-
$useIgbinarySerialize = \extension_loaded('igbinary') && (\PHP_VERSION_ID < 70400 || version_compare('3.1.6', phpversion('igbinary'), '<='));
29-
} elseif ($useIgbinarySerialize && (!\extension_loaded('igbinary') || (\PHP_VERSION_ID >= 70400 && version_compare('3.1.6', phpversion('igbinary'), '>')))) {
30-
throw new CacheException(\extension_loaded('igbinary') && \PHP_VERSION_ID >= 70400 ? 'Please upgrade the "igbinary" PHP extension to v3.1.6 or higher.' : 'The "igbinary" PHP extension is not loaded.');
28+
$useIgbinarySerialize = \extension_loaded('igbinary') && version_compare('3.1.6', phpversion('igbinary'), '<=');
29+
} elseif ($useIgbinarySerialize && (!\extension_loaded('igbinary') || version_compare('3.1.6', phpversion('igbinary'), '>'))) {
30+
throw new CacheException(\extension_loaded('igbinary') ? 'Please upgrade the "igbinary" PHP extension to v3.1.6 or higher.' : 'The "igbinary" PHP extension is not loaded.');
3131
}
3232
$this->useIgbinarySerialize = $useIgbinarySerialize;
3333
}

‎src/Symfony/Component/Cache/Tests/Adapter/MemcachedAdapterTest.php

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -72,13 +72,8 @@ public function testOptions()
7272
*/
7373
public function testBadOptions($name, $value)
7474
{
75-
if (\PHP_VERSION_ID < 80000) {
76-
$this->expectException(\ErrorException::class);
77-
$this->expectExceptionMessage('constant(): Couldn\'t find constant Memcached::');
78-
} else {
79-
$this->expectException(\Error::class);
80-
$this->expectExceptionMessage('Undefined constant Memcached::');
81-
}
75+
$this->expectException(\Error::class);
76+
$this->expectExceptionMessage('Undefined constant Memcached::');
8277

8378
MemcachedAdapter::createConnection([], [$name => $value]);
8479
}

‎src/Symfony/Component/Cache/Tests/Marshaller/DefaultMarshallerTest.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ public function testSerialize()
2424
'b' => function () {},
2525
];
2626

27-
$expected = ['a' => \extension_loaded('igbinary') && (\PHP_VERSION_ID < 70400 || version_compare('3.1.6', phpversion('igbinary'), '<=')) ? igbinary_serialize(123) : serialize(123)];
27+
$expected = ['a' => \extension_loaded('igbinary') && (version_compare('3.1.6', phpversion('igbinary'), '<=')) ? igbinary_serialize(123) : serialize(123)];
2828
$this->assertSame($expected, $marshaller->marshall($values, $failed));
2929
$this->assertSame(['b'], $failed);
3030
}
@@ -43,7 +43,7 @@ public function testNativeUnserialize()
4343
*/
4444
public function testIgbinaryUnserialize()
4545
{
46-
if (\PHP_VERSION_ID >= 70400 && version_compare('3.1.6', phpversion('igbinary'), '>')) {
46+
if (version_compare('3.1.6', phpversion('igbinary'), '>')) {
4747
$this->markTestSkipped('igbinary is not compatible with PHP 7.4.');
4848
}
4949

@@ -67,7 +67,7 @@ public function testNativeUnserializeNotFoundClass()
6767
*/
6868
public function testIgbinaryUnserializeNotFoundClass()
6969
{
70-
if (\PHP_VERSION_ID >= 70400 && version_compare('3.1.6', phpversion('igbinary'), '>')) {
70+
if (version_compare('3.1.6', phpversion('igbinary'), '>')) {
7171
$this->markTestSkipped('igbinary is not compatible with PHP 7.4.');
7272
}
7373

@@ -95,7 +95,7 @@ public function testNativeUnserializeInvalid()
9595
*/
9696
public function testIgbinaryUnserializeInvalid()
9797
{
98-
if (\PHP_VERSION_ID >= 70400 && version_compare('3.1.6', phpversion('igbinary'), '>')) {
98+
if (version_compare('3.1.6', phpversion('igbinary'), '>')) {
9999
$this->markTestSkipped('igbinary is not compatible with PHP 7.4.');
100100
}
101101

‎src/Symfony/Component/Config/Resource/ClassExistenceResource.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,7 @@ public static function throwOnRequiredClass(string $class, \Exception $previous
190190
'args' => [$class],
191191
];
192192

193-
if (\PHP_VERSION_ID >= 80000 && isset($trace[1])) {
193+
if (isset($trace[1])) {
194194
$callerFrame = $trace[1];
195195
$i = 2;
196196
} elseif (false !== $i = array_search($autoloadFrame, $trace, true)) {

‎src/Symfony/Component/Config/Tests/Resource/ReflectionClassResourceTest.php

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -143,13 +143,11 @@ public function provideHashedSignature(): iterable
143143
yield [0, 14, '/** priv docblock */'];
144144
yield [0, 15, ''];
145145

146-
if (\PHP_VERSION_ID >= 70400) {
147-
// PHP7.4 typed properties without default value are
148-
// undefined, make sure this doesn't throw an error
149-
yield [1, 5, 'public array $pub;'];
150-
yield [0, 7, 'protected int $prot;'];
151-
yield [0, 9, 'private string $priv;'];
152-
}
146+
// PHP7.4 typed properties without default value are
147+
// undefined, make sure this doesn't throw an error
148+
yield [1, 5, 'public array $pub;'];
149+
yield [0, 7, 'protected int $prot;'];
150+
yield [0, 9, 'private string $priv;'];
153151

154152
yield [1, 17, 'public function ccc($bar = 187) {}'];
155153
yield [1, 17, 'public function ccc($bar = ANOTHER_ONE_THAT_WILL_NEVER_BE_DEFINED_CCCCCCCCC) {}'];

‎src/Symfony/Component/Console/Command/Command.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ public static function getDefaultName()
6767
{
6868
$class = static::class;
6969

70-
if (\PHP_VERSION_ID >= 80000 && $attribute = (new \ReflectionClass($class))->getAttributes(AsCommand::class)) {
70+
if ($attribute = (new \ReflectionClass($class))->getAttributes(AsCommand::class)) {
7171
return $attribute[0]->newInstance()->name;
7272
}
7373

@@ -83,7 +83,7 @@ public static function getDefaultDescription(): ?string
8383
{
8484
$class = static::class;
8585

86-
if (\PHP_VERSION_ID >= 80000 && $attribute = (new \ReflectionClass($class))->getAttributes(AsCommand::class)) {
86+
if ($attribute = (new \ReflectionClass($class))->getAttributes(AsCommand::class)) {
8787
return $attribute[0]->newInstance()->description;
8888
}
8989

‎src/Symfony/Component/Console/Tests/Command/CommandTest.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -406,9 +406,6 @@ public function testSetCodeWithStaticAnonymousFunction()
406406
$this->assertEquals('interact called'.\PHP_EOL.'not bound'.\PHP_EOL, $tester->getDisplay());
407407
}
408408

409-
/**
410-
* @requires PHP 8
411-
*/
412409
public function testCommandAttribute()
413410
{
414411
$this->assertSame('|foo|f', Php8Command::getDefaultName());

‎src/Symfony/Component/DependencyInjection/Attribute/Target.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ public function __construct(string $name)
3333

3434
public static function parseName(\ReflectionParameter $parameter): string
3535
{
36-
if (80000 > \PHP_VERSION_ID || !$target = $parameter->getAttributes(self::class)[0] ?? null) {
36+
if (!$target = $parameter->getAttributes(self::class)[0] ?? null) {
3737
return $parameter->name;
3838
}
3939

‎src/Symfony/Component/DependencyInjection/Compiler/AttributeAutoconfigurationPass.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ final class AttributeAutoconfigurationPass extends AbstractRecursivePass
2222
{
2323
public function process(ContainerBuilder $container): void
2424
{
25-
if (80000 > \PHP_VERSION_ID || !$container->getAutoconfiguredAttributes()) {
25+
if (!$container->getAutoconfiguredAttributes()) {
2626
return;
2727
}
2828

‎src/Symfony/Component/DependencyInjection/Compiler/AutowirePass.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ private function doProcessValue($value, bool $isRoot = false)
129129
array_unshift($this->methodCalls, [$constructor, $value->getArguments()]);
130130
}
131131

132-
$checkAttributes = 80000 <= \PHP_VERSION_ID && !$value->hasTag('container.ignore_attributes');
132+
$checkAttributes = !$value->hasTag('container.ignore_attributes');
133133
$this->methodCalls = $this->autowireCalls($reflectionClass, $isRoot, $checkAttributes);
134134

135135
if ($constructor) {

‎src/Symfony/Component/DependencyInjection/Compiler/AutowireRequiredMethodsPass.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ protected function processValue($value, bool $isRoot = false)
5050
}
5151

5252
while (true) {
53-
if (\PHP_VERSION_ID >= 80000 && $r->getAttributes(Required::class)) {
53+
if ($r->getAttributes(Required::class)) {
5454
if ($this->isWither($r, $r->getDocComment() ?: '')) {
5555
$withers[] = [$r->name, [], true];
5656
} else {

‎src/Symfony/Component/DependencyInjection/Compiler/AutowireRequiredPropertiesPass.php

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,6 @@ class AutowireRequiredPropertiesPass extends AbstractRecursivePass
2929
*/
3030
protected function processValue($value, bool $isRoot = false)
3131
{
32-
if (\PHP_VERSION_ID < 70400) {
33-
return $value;
34-
}
3532
$value = parent::processValue($value, $isRoot);
3633

3734
if (!$value instanceof Definition || !$value->isAutowired() || $value->isAbstract() || !$value->getClass()) {
@@ -46,7 +43,7 @@ protected function processValue($value, bool $isRoot = false)
4643
if (!($type = $reflectionProperty->getType()) instanceof \ReflectionNamedType) {
4744
continue;
4845
}
49-
if ((\PHP_VERSION_ID < 80000 || !$reflectionProperty->getAttributes(Required::class))
46+
if (!$reflectionProperty->getAttributes(Required::class)
5047
&& ((false === $doc = $reflectionProperty->getDocComment()) || false === stripos($doc, '@required') || !preg_match('#(?:^/\*\*|\n\s*+\*)\s*+@required(?:\s|\*/$)#i', $doc))
5148
) {
5249
continue;

‎src/Symfony/Component/DependencyInjection/Compiler/PriorityTaggedServiceTrait.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ private function findAndSortTaggedServices($tagName, ContainerBuilder $container
6060
$definition = $container->getDefinition($serviceId);
6161
$class = $definition->getClass();
6262
$class = $container->getParameterBag()->resolveValue($class) ?: null;
63-
$checkTaggedItem = !$definition->hasTag(80000 <= \PHP_VERSION_ID && $definition->isAutoconfigured() ? 'container.ignore_attributes' : $tagName);
63+
$checkTaggedItem = !$definition->hasTag($definition->isAutoconfigured() ? 'container.ignore_attributes' : $tagName);
6464

6565
foreach ($attributes as $attribute) {
6666
$index = $priority = null;

‎src/Symfony/Component/DependencyInjection/Compiler/RegisterAutoconfigureAttributesPass.php

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,10 +31,6 @@ final class RegisterAutoconfigureAttributesPass implements CompilerPassInterface
3131
*/
3232
public function process(ContainerBuilder $container)
3333
{
34-
if (80000 > \PHP_VERSION_ID) {
35-
return;
36-
}
37-
3834
foreach ($container->getDefinitions() as $id => $definition) {
3935
if ($this->accept($definition) && null !== $class = $container->getReflectionClass($definition->getClass())) {
4036
$this->processClass($container, $class);
@@ -44,7 +40,7 @@ public function process(ContainerBuilder $container)
4440

4541
public function accept(Definition $definition): bool
4642
{
47-
return 80000 <= \PHP_VERSION_ID && $definition->isAutoconfigured() && !$definition->hasTag('container.ignore_attributes');
43+
return $definition->isAutoconfigured() && !$definition->hasTag('container.ignore_attributes');
4844
}
4945

5046
public function processClass(ContainerBuilder $container, \ReflectionClass $class)

‎src/Symfony/Component/DependencyInjection/Dumper/Preloader.php

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -85,10 +85,8 @@ private static function doPreload(string $class, array &$preloaded): void
8585
$r->getConstants();
8686
$r->getDefaultProperties();
8787

88-
if (\PHP_VERSION_ID >= 70400) {
89-
foreach ($r->getProperties(\ReflectionProperty::IS_PUBLIC) as $p) {
90-
self::preloadType($p->getType(), $preloaded);
91-
}
88+
foreach ($r->getProperties(\ReflectionProperty::IS_PUBLIC) as $p) {
89+
self::preloadType($p->getType(), $preloaded);
9290
}
9391

9492
foreach ($r->getMethods(\ReflectionMethod::IS_PUBLIC) as $m) {

‎src/Symfony/Component/DependencyInjection/EnvVarProcessor.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ public function getEnv(string $prefix, string $name, \Closure $getEnv)
192192
return (string) $env;
193193
}
194194

195-
if (in_array($prefix, ['bool', 'not'], true)) {
195+
if (\in_array($prefix, ['bool', 'not'], true)) {
196196
$env = (bool) (filter_var($env, \FILTER_VALIDATE_BOOLEAN) ?: filter_var($env, \FILTER_VALIDATE_INT) ?: filter_var($env, \FILTER_VALIDATE_FLOAT));
197197

198198
return 'not' === $prefix ? !$env : $env;
@@ -288,7 +288,7 @@ public function getEnv(string $prefix, string $name, \Closure $getEnv)
288288
}
289289

290290
if ('csv' === $prefix) {
291-
return str_getcsv($env, ',', '"', \PHP_VERSION_ID >= 70400 ? '' : '\\');
291+
return str_getcsv($env, ',', '"', '');
292292
}
293293

294294
if ('trim' === $prefix) {

‎src/Symfony/Component/DependencyInjection/Loader/PhpFileLoader.php

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -101,18 +101,16 @@ private function executeCallback(callable $callback, ContainerConfigurator $cont
101101
$configBuilders = [];
102102
$r = new \ReflectionFunction($callback);
103103

104-
if (\PHP_VERSION_ID >= 80000) {
105-
$attribute = null;
106-
foreach ($r->getAttributes(When::class) as $attribute) {
107-
if ($this->env === $attribute->newInstance()->env) {
108-
$attribute = null;
109-
break;
110-
}
111-
}
112-
if (null !== $attribute) {
113-
return;
104+
$attribute = null;
105+
foreach ($r->getAttributes(When::class) as $attribute) {
106+
if ($this->env === $attribute->newInstance()->env) {
107+
$attribute = null;
108+
break;
114109
}
115110
}
111+
if (null !== $attribute) {
112+
return;
113+
}
116114

117115
foreach ($r->getParameters() as $parameter) {
118116
$reflectionType = $parameter->getType();

‎src/Symfony/Component/DependencyInjection/Loader/XmlFileLoader.php

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -669,11 +669,6 @@ public function validateSchema(\DOMDocument $dom)
669669

670670
private function shouldEnableEntityLoader(): bool
671671
{
672-
// Version prior to 8.0 can be enabled without deprecation
673-
if (\PHP_VERSION_ID < 80000) {
674-
return true;
675-
}
676-
677672
static $dom, $schema;
678673
if (null === $dom) {
679674
$dom = new \DOMDocument();

‎src/Symfony/Component/DependencyInjection/Tests/Compiler/AttributeAutoconfigurationPassTest.php

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,6 @@
1616
use Symfony\Component\DependencyInjection\Compiler\AttributeAutoconfigurationPass;
1717
use Symfony\Component\DependencyInjection\ContainerBuilder;
1818

19-
/**
20-
* @requires PHP 8
21-
*/
2219
class AttributeAutoconfigurationPassTest extends TestCase
2320
{
2421
public function testProcessAddsNoEmptyInstanceofConditionals()

0 commit comments

Comments
 (0)