[Serializer] Fix collecting only first missing constructor argument

HypeMC · HypeMC · commit 258ae0fd75fc · 2023-10-10T01:27:16.000+02:00
diff --git a/src/Symfony/Component/Serializer/Normalizer/AbstractNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/AbstractNormalizer.php
@@ -413,8 +413,6 @@ protected function instantiateObject(array &$data, string $class, array &$contex
                         true
                     );
                     $context['not_normalizable_value_exceptions'][] = $exception;
-
-                    return $reflectionClass->newInstanceWithoutConstructor();
                 }
             }
 
diff --git a/src/Symfony/Component/Serializer/Tests/Fixtures/Php80WithPromotedTypedConstructor.php b/src/Symfony/Component/Serializer/Tests/Fixtures/Php80WithPromotedTypedConstructor.php
@@ -13,7 +13,10 @@
 
 final class Php80WithPromotedTypedConstructor
 {
-    public function __construct(public bool $bool)
-    {
+    public function __construct(
+        public bool $bool,
+        public string $string,
+        public int $int,
+    ) {
     }
 }
diff --git a/src/Symfony/Component/Serializer/Tests/Normalizer/Features/ConstructorArgumentsTestTrait.php b/src/Symfony/Component/Serializer/Tests/Normalizer/Features/ConstructorArgumentsTestTrait.php
@@ -70,4 +70,22 @@ public function testConstructorWithMissingData()
             self::assertSame(['bar', 'baz'], $e->getMissingConstructorArguments());
         }
     }
+
+    public function testExceptionsAreCollectedForConstructorWithMissingData()
+    {
+        $data = [
+            'foo' => 10,
+        ];
+
+        $exceptions = [];
+
+        $normalizer = $this->getDenormalizerForConstructArguments();
+        $normalizer->denormalize($data, ConstructorArgumentsObject::class, null, [
+            'not_normalizable_value_exceptions' => &$exceptions,
+        ]);
+
+        self::assertCount(2, $exceptions);
+        self::assertSame('Failed to create object because the class misses the "bar" property.', $exceptions[0]->getMessage());
+        self::assertSame('Failed to create object because the class misses the "baz" property.', $exceptions[1]->getMessage());
+    }
 }
diff --git a/src/Symfony/Component/Serializer/Tests/SerializerTest.php b/src/Symfony/Component/Serializer/Tests/SerializerTest.php
@@ -1196,6 +1196,24 @@ public function testCollectDenormalizationErrorsWithConstructor(?ClassMetadataFa
                 'useMessageForUser' => false,
                 'message' => 'The type of the "bool" attribute for class "Symfony\\Component\\Serializer\\Tests\\Fixtures\\Php80WithPromotedTypedConstructor" must be one of "bool" ("string" given).',
             ],
+            [
+                'currentType' => 'array',
+                'expectedTypes' => [
+                    'unknown',
+                ],
+                'path' => null,
+                'useMessageForUser' => true,
+                'message' => 'Failed to create object because the class misses the "string" property.',
+            ],
+            [
+                'currentType' => 'array',
+                'expectedTypes' => [
+                    'unknown',
+                ],
+                'path' => null,
+                'useMessageForUser' => true,
+                'message' => 'Failed to create object because the class misses the "int" property.',
+            ],
         ];
 
         $this->assertSame($expected, $exceptionsAsArray);

Original file line number	Diff line number	Diff line change
`@@ -413,8 +413,6 @@ protected function instantiateObject(array &$data, string $class, array &$contex`
`413`	`413`	`true`
`414`	`414`	`);`
`415`	`415`	`$context['not_normalizable_value_exceptions'][] = $exception;`
`416`		`-`
`417`		`- return $reflectionClass->newInstanceWithoutConstructor();`
`418`	`416`	`}`
`419`	`417`	`}`
`420`	`418`
Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,10 @@`
`13`	`13`
`14`	`14`	`final class Php80WithPromotedTypedConstructor`
`15`	`15`	`{`
`16`		`- public function __construct(public bool $bool)`
`17`		`- {`
	`16`	`+ public function __construct(`
	`17`	`+ public bool $bool,`
	`18`	`+ public string $string,`
	`19`	`+ public int $int,`
	`20`	`+ ) {`
`18`	`21`	`}`
`19`	`22`	`}`