[Serializer] Trigger depreciations on hasCacheableSupportsMethod calls

tucksaun · tucksaun · commit 25b94bc66012 · 2023-02-10T15:57:48.000-05:00
diff --git a/src/Symfony/Component/Serializer/Normalizer/BackedEnumNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/BackedEnumNormalizer.php
@@ -25,7 +25,7 @@ final class BackedEnumNormalizer implements NormalizerInterface, DenormalizerInt
     public function getSupportedTypes(): array
     {
         return [
-           \BackedEnum::class => $this->hasCacheableSupportsMethod(),
+           \BackedEnum::class => true,
         ];
     }
 
@@ -70,6 +70,8 @@ public function supportsDenormalization(mixed $data, string $type, string $forma
 
     public function hasCacheableSupportsMethod(): bool
     {
+        trigger_deprecation('symfony/serializer', '6.3', 'CacheableSupportsMethodInterface::hasCacheableSupportsMethod() is deprecated, use "getSupportedTypes()" return value instead.');
+
         return true;
     }
 }
diff --git a/src/Symfony/Component/Serializer/Normalizer/ConstraintViolationListNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/ConstraintViolationListNormalizer.php
@@ -42,7 +42,7 @@ public function __construct(array $defaultContext = [], NameConverterInterface $
     public function getSupportedTypes(): ?array
     {
         return [
-            ConstraintViolationListInterface::class => $this->hasCacheableSupportsMethod(),
+            ConstraintViolationListInterface::class => __CLASS__ == static::class,
         ];
     }
 
@@ -118,6 +118,8 @@ public function supportsNormalization(mixed $data, string $format = null /* , ar
 
     public function hasCacheableSupportsMethod(): bool
     {
+        trigger_deprecation('symfony/serializer', '6.3', 'CacheableSupportsMethodInterface::hasCacheableSupportsMethod() is deprecated, use "getSupportedTypes()" return value instead.');
+
         return __CLASS__ === static::class;
     }
 }
diff --git a/src/Symfony/Component/Serializer/Normalizer/CustomNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/CustomNormalizer.php
@@ -25,7 +25,7 @@ class CustomNormalizer implements NormalizerInterface, DenormalizerInterface, Se
     public function getSupportedTypes(): array
     {
         return [
-            NormalizableInterface::class => $this->hasCacheableSupportsMethod(),
+            NormalizableInterface::class => __CLASS__ === static::class,
         ];
     }
 
@@ -69,6 +69,8 @@ public function supportsDenormalization(mixed $data, string $type, string $forma
 
     public function hasCacheableSupportsMethod(): bool
     {
+        trigger_deprecation('symfony/serializer', '6.3', 'CacheableSupportsMethodInterface::hasCacheableSupportsMethod() is deprecated, use "getSupportedTypes()" return value instead.');
+
         return __CLASS__ === static::class;
     }
 }
diff --git a/src/Symfony/Component/Serializer/Normalizer/DataUriNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/DataUriNormalizer.php
@@ -125,6 +125,8 @@ public function supportsDenormalization(mixed $data, string $type, string $forma
 
     public function hasCacheableSupportsMethod(): bool
     {
+        trigger_deprecation('symfony/serializer', '6.3', 'CacheableSupportsMethodInterface::hasCacheableSupportsMethod() is deprecated, use "getSupportedTypes()" return value instead.');
+
         return __CLASS__ === static::class;
     }
 
diff --git a/src/Symfony/Component/Serializer/Normalizer/DateIntervalNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/DateIntervalNormalizer.php
@@ -36,7 +36,7 @@ public function __construct(array $defaultContext = [])
     public function getSupportedTypes(): array
     {
         return [
-            \DateInterval::class => $this->hasCacheableSupportsMethod(),
+            \DateInterval::class => __CLASS__ === static::class,
         ];
     }
 
@@ -62,6 +62,8 @@ public function supportsNormalization(mixed $data, string $format = null /* , ar
 
     public function hasCacheableSupportsMethod(): bool
     {
+        trigger_deprecation('symfony/serializer', '6.3', 'CacheableSupportsMethodInterface::hasCacheableSupportsMethod() is deprecated, use "getSupportedTypes()" return value instead.');
+
         return __CLASS__ === static::class;
     }
 
diff --git a/src/Symfony/Component/Serializer/Normalizer/DateTimeNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/DateTimeNormalizer.php
@@ -131,6 +131,8 @@ public function supportsDenormalization(mixed $data, string $type, string $forma
 
     public function hasCacheableSupportsMethod(): bool
     {
+        trigger_deprecation('symfony/serializer', '6.3', 'CacheableSupportsMethodInterface::hasCacheableSupportsMethod() is deprecated, use "getSupportedTypes()" return value instead.');
+
         return __CLASS__ === static::class;
     }
 
diff --git a/src/Symfony/Component/Serializer/Normalizer/DateTimeZoneNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/DateTimeZoneNormalizer.php
@@ -25,7 +25,7 @@ class DateTimeZoneNormalizer implements NormalizerInterface, DenormalizerInterfa
     public function getSupportedTypes(): array
     {
         return [
-            \DateTimeZone::class => $this->hasCacheableSupportsMethod(),
+            \DateTimeZone::class => __CLASS__ === static::class,
         ];
     }
 
@@ -75,6 +75,8 @@ public function supportsDenormalization(mixed $data, string $type, string $forma
 
     public function hasCacheableSupportsMethod(): bool
     {
+        trigger_deprecation('symfony/serializer', '6.3', 'CacheableSupportsMethodInterface::hasCacheableSupportsMethod() is deprecated, use "getSupportedTypes()" return value instead.');
+
         return __CLASS__ === static::class;
     }
 }
diff --git a/src/Symfony/Component/Serializer/Normalizer/FormErrorNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/FormErrorNormalizer.php
@@ -41,7 +41,7 @@ public function normalize(mixed $object, string $format = null, array $context =
     public function getSupportedTypes(): array
     {
         return [
-            FormInterface::class => $this->hasCacheableSupportsMethod(),
+            FormInterface::class => __CLASS__ == self::class,
         ];
     }
 
@@ -85,6 +85,8 @@ private function convertFormChildrenToArray(FormInterface $data): array
 
     public function hasCacheableSupportsMethod(): bool
     {
+        trigger_deprecation('symfony/serializer', '6.3', 'CacheableSupportsMethodInterface::hasCacheableSupportsMethod() is deprecated, use "getSupportedTypes()" return value instead.');
+
         return __CLASS__ === static::class;
     }
 }
diff --git a/src/Symfony/Component/Serializer/Normalizer/JsonSerializableNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/JsonSerializableNormalizer.php
@@ -41,7 +41,7 @@ public function normalize(mixed $object, string $format = null, array $context =
     public function getSupportedTypes(): array
     {
         return [
-            \JsonSerializable::class => $this->hasCacheableSupportsMethod(),
+            \JsonSerializable::class => __CLASS__ === static::class,
         ];
     }
 
@@ -68,6 +68,8 @@ public function denormalize(mixed $data, string $type, string $format = null, ar
 
     public function hasCacheableSupportsMethod(): bool
     {
+        trigger_deprecation('symfony/serializer', '6.3', 'CacheableSupportsMethodInterface::hasCacheableSupportsMethod() is deprecated, use "getSupportedTypes()" return value instead.');
+
         return __CLASS__ === static::class;
     }
 }
diff --git a/src/Symfony/Component/Serializer/Normalizer/MimeMessageNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/MimeMessageNormalizer.php
@@ -45,11 +45,11 @@ public function __construct(PropertyNormalizer $normalizer)
     public function getSupportedTypes(): array
     {
         return [
-            Message::class => $this->hasCacheableSupportsMethod(),
-            Headers::class => $this->hasCacheableSupportsMethod(),
-            HeaderInterface::class => $this->hasCacheableSupportsMethod(),
-            Address::class => $this->hasCacheableSupportsMethod(),
-            AbstractPart::class => $this->hasCacheableSupportsMethod(),
+            Message::class => true,
+            Headers::class => true,
+            HeaderInterface::class => true,
+            Address::class => true,
+            AbstractPart::class => true,
         ];
     }
 
@@ -114,6 +114,8 @@ public function supportsDenormalization(mixed $data, string $type, string $forma
 
     public function hasCacheableSupportsMethod(): bool
     {
+        trigger_deprecation('symfony/serializer', '6.3', 'CacheableSupportsMethodInterface::hasCacheableSupportsMethod() is deprecated, use "getSupportedTypes()" return value instead.');
+
         return __CLASS__ === static::class;
     }
 }
diff --git a/src/Symfony/Component/Serializer/Normalizer/ProblemNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/ProblemNormalizer.php
@@ -43,7 +43,7 @@ public function __construct(bool $debug = false, array $defaultContext = [])
     public function getSupportedTypes(): array
     {
         return [
-            FlattenException::class => $this->hasCacheableSupportsMethod(),
+            FlattenException::class => __CLASS__ === self::class,
         ];
     }
 
@@ -80,6 +80,8 @@ public function supportsNormalization(mixed $data, string $format = null /* , ar
 
     public function hasCacheableSupportsMethod(): bool
     {
+        trigger_deprecation('symfony/serializer', '6.3', 'CacheableSupportsMethodInterface::hasCacheableSupportsMethod() is deprecated, use "getSupportedTypes()" return value instead.');
+
         return true;
     }
 }
diff --git a/src/Symfony/Component/Serializer/Normalizer/UidNormalizer.php b/src/Symfony/Component/Serializer/Normalizer/UidNormalizer.php
@@ -44,7 +44,7 @@ public function __construct(array $defaultContext = [])
     public function getSupportedTypes(): array
     {
         return [
-            AbstractUid::class => $this->hasCacheableSupportsMethod(),
+            AbstractUid::class => true,
         ];
     }
 
@@ -101,6 +101,8 @@ public function supportsDenormalization(mixed $data, string $type, string $forma
 
     public function hasCacheableSupportsMethod(): bool
     {
+        trigger_deprecation('symfony/serializer', '6.3', 'CacheableSupportsMethodInterface::hasCacheableSupportsMethod() is deprecated, use "getSupportedTypes()" return value instead.');
+
         return __CLASS__ === static::class;
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ final class BackedEnumNormalizer implements NormalizerInterface, DenormalizerInt`
`25`	`25`	`public function getSupportedTypes(): array`
`26`	`26`	`{`
`27`	`27`	`return [`
`28`		`- \BackedEnum::class => $this->hasCacheableSupportsMethod(),`
	`28`	`+ \BackedEnum::class => true,`
`29`	`29`	`];`
`30`	`30`	`}`
`31`	`31`
`@@ -70,6 +70,8 @@ public function supportsDenormalization(mixed $data, string $type, string $forma`
`70`	`70`
`71`	`71`	`public function hasCacheableSupportsMethod(): bool`
`72`	`72`	`{`
	`73`	`+ trigger_deprecation('symfony/serializer', '6.3', 'CacheableSupportsMethodInterface::hasCacheableSupportsMethod() is deprecated, use "getSupportedTypes()" return value instead.');`
	`74`	`+`
`73`	`75`	`return true;`
`74`	`76`	`}`
`75`	`77`	`}`
Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ public function __construct(array $defaultContext = [], NameConverterInterface $`
`42`	`42`	`public function getSupportedTypes(): ?array`
`43`	`43`	`{`
`44`	`44`	`return [`
`45`		`- ConstraintViolationListInterface::class => $this->hasCacheableSupportsMethod(),`
	`45`	`+ ConstraintViolationListInterface::class => __CLASS__ == static::class,`
`46`	`46`	`];`
`47`	`47`	`}`
`48`	`48`
`@@ -118,6 +118,8 @@ public function supportsNormalization(mixed $data, string $format = null /* , ar`
`118`	`118`
`119`	`119`	`public function hasCacheableSupportsMethod(): bool`
`120`	`120`	`{`
	`121`	`+ trigger_deprecation('symfony/serializer', '6.3', 'CacheableSupportsMethodInterface::hasCacheableSupportsMethod() is deprecated, use "getSupportedTypes()" return value instead.');`
	`122`	`+`
`121`	`123`	`return __CLASS__ === static::class;`
`122`	`124`	`}`
`123`	`125`	`}`
Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ class CustomNormalizer implements NormalizerInterface, DenormalizerInterface, Se`
`25`	`25`	`public function getSupportedTypes(): array`
`26`	`26`	`{`
`27`	`27`	`return [`
`28`		`- NormalizableInterface::class => $this->hasCacheableSupportsMethod(),`
	`28`	`+ NormalizableInterface::class => __CLASS__ === static::class,`
`29`	`29`	`];`
`30`	`30`	`}`
`31`	`31`
`@@ -69,6 +69,8 @@ public function supportsDenormalization(mixed $data, string $type, string $forma`
`69`	`69`
`70`	`70`	`public function hasCacheableSupportsMethod(): bool`
`71`	`71`	`{`
	`72`	`+ trigger_deprecation('symfony/serializer', '6.3', 'CacheableSupportsMethodInterface::hasCacheableSupportsMethod() is deprecated, use "getSupportedTypes()" return value instead.');`
	`73`	`+`
`72`	`74`	`return __CLASS__ === static::class;`
`73`	`75`	`}`
`74`	`76`	`}`
Original file line number	Diff line number	Diff line change
`@@ -125,6 +125,8 @@ public function supportsDenormalization(mixed $data, string $type, string $forma`
`125`	`125`
`126`	`126`	`public function hasCacheableSupportsMethod(): bool`
`127`	`127`	`{`
	`128`	`+ trigger_deprecation('symfony/serializer', '6.3', 'CacheableSupportsMethodInterface::hasCacheableSupportsMethod() is deprecated, use "getSupportedTypes()" return value instead.');`
	`129`	`+`
`128`	`130`	`return __CLASS__ === static::class;`
`129`	`131`	`}`
`130`	`132`
Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ public function __construct(array $defaultContext = [])`
`36`	`36`	`public function getSupportedTypes(): array`
`37`	`37`	`{`
`38`	`38`	`return [`
`39`		`- \DateInterval::class => $this->hasCacheableSupportsMethod(),`
	`39`	`+ \DateInterval::class => __CLASS__ === static::class,`
`40`	`40`	`];`
`41`	`41`	`}`
`42`	`42`
`@@ -62,6 +62,8 @@ public function supportsNormalization(mixed $data, string $format = null /* , ar`
`62`	`62`
`63`	`63`	`public function hasCacheableSupportsMethod(): bool`
`64`	`64`	`{`
	`65`	`+ trigger_deprecation('symfony/serializer', '6.3', 'CacheableSupportsMethodInterface::hasCacheableSupportsMethod() is deprecated, use "getSupportedTypes()" return value instead.');`
	`66`	`+`
`65`	`67`	`return __CLASS__ === static::class;`
`66`	`68`	`}`
`67`	`69`
Original file line number	Diff line number	Diff line change
`@@ -131,6 +131,8 @@ public function supportsDenormalization(mixed $data, string $type, string $forma`
`131`	`131`
`132`	`132`	`public function hasCacheableSupportsMethod(): bool`
`133`	`133`	`{`
	`134`	`+ trigger_deprecation('symfony/serializer', '6.3', 'CacheableSupportsMethodInterface::hasCacheableSupportsMethod() is deprecated, use "getSupportedTypes()" return value instead.');`
	`135`	`+`
`134`	`136`	`return __CLASS__ === static::class;`
`135`	`137`	`}`
`136`	`138`
Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ class DateTimeZoneNormalizer implements NormalizerInterface, DenormalizerInterfa`
`25`	`25`	`public function getSupportedTypes(): array`
`26`	`26`	`{`
`27`	`27`	`return [`
`28`		`- \DateTimeZone::class => $this->hasCacheableSupportsMethod(),`
	`28`	`+ \DateTimeZone::class => __CLASS__ === static::class,`
`29`	`29`	`];`
`30`	`30`	`}`
`31`	`31`
`@@ -75,6 +75,8 @@ public function supportsDenormalization(mixed $data, string $type, string $forma`
`75`	`75`
`76`	`76`	`public function hasCacheableSupportsMethod(): bool`
`77`	`77`	`{`
	`78`	`+ trigger_deprecation('symfony/serializer', '6.3', 'CacheableSupportsMethodInterface::hasCacheableSupportsMethod() is deprecated, use "getSupportedTypes()" return value instead.');`
	`79`	`+`
`78`	`80`	`return __CLASS__ === static::class;`
`79`	`81`	`}`
`80`	`82`	`}`
Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ public function normalize(mixed $object, string $format = null, array $context =`
`41`	`41`	`public function getSupportedTypes(): array`
`42`	`42`	`{`
`43`	`43`	`return [`
`44`		`- FormInterface::class => $this->hasCacheableSupportsMethod(),`
	`44`	`+ FormInterface::class => __CLASS__ == self::class,`
`45`	`45`	`];`
`46`	`46`	`}`
`47`	`47`
`@@ -85,6 +85,8 @@ private function convertFormChildrenToArray(FormInterface $data): array`
`85`	`85`
`86`	`86`	`public function hasCacheableSupportsMethod(): bool`
`87`	`87`	`{`
	`88`	`+ trigger_deprecation('symfony/serializer', '6.3', 'CacheableSupportsMethodInterface::hasCacheableSupportsMethod() is deprecated, use "getSupportedTypes()" return value instead.');`
	`89`	`+`
`88`	`90`	`return __CLASS__ === static::class;`
`89`	`91`	`}`
`90`	`92`	`}`
Original file line number	Diff line number	Diff line change
`@@ -45,11 +45,11 @@ public function __construct(PropertyNormalizer $normalizer)`
`45`	`45`	`public function getSupportedTypes(): array`
`46`	`46`	`{`
`47`	`47`	`return [`
`48`		`- Message::class => $this->hasCacheableSupportsMethod(),`
`49`		`- Headers::class => $this->hasCacheableSupportsMethod(),`
`50`		`- HeaderInterface::class => $this->hasCacheableSupportsMethod(),`
`51`		`- Address::class => $this->hasCacheableSupportsMethod(),`
`52`		`- AbstractPart::class => $this->hasCacheableSupportsMethod(),`
	`48`	`+ Message::class => true,`
	`49`	`+ Headers::class => true,`
	`50`	`+ HeaderInterface::class => true,`
	`51`	`+ Address::class => true,`
	`52`	`+ AbstractPart::class => true,`
`53`	`53`	`];`
`54`	`54`	`}`
`55`	`55`
`@@ -114,6 +114,8 @@ public function supportsDenormalization(mixed $data, string $type, string $forma`
`114`	`114`
`115`	`115`	`public function hasCacheableSupportsMethod(): bool`
`116`	`116`	`{`
	`117`	`+ trigger_deprecation('symfony/serializer', '6.3', 'CacheableSupportsMethodInterface::hasCacheableSupportsMethod() is deprecated, use "getSupportedTypes()" return value instead.');`
	`118`	`+`
`117`	`119`	`return __CLASS__ === static::class;`
`118`	`120`	`}`
`119`	`121`	`}`
Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ public function __construct(bool $debug = false, array $defaultContext = [])`
`43`	`43`	`public function getSupportedTypes(): array`
`44`	`44`	`{`
`45`	`45`	`return [`
`46`		`- FlattenException::class => $this->hasCacheableSupportsMethod(),`
	`46`	`+ FlattenException::class => __CLASS__ === self::class,`
`47`	`47`	`];`
`48`	`48`	`}`
`49`	`49`
`@@ -80,6 +80,8 @@ public function supportsNormalization(mixed $data, string $format = null /* , ar`
`80`	`80`
`81`	`81`	`public function hasCacheableSupportsMethod(): bool`
`82`	`82`	`{`
	`83`	`+ trigger_deprecation('symfony/serializer', '6.3', 'CacheableSupportsMethodInterface::hasCacheableSupportsMethod() is deprecated, use "getSupportedTypes()" return value instead.');`
	`84`	`+`
`83`	`85`	`return true;`
`84`	`86`	`}`
`85`	`87`	`}`