merged branch jmikola/memcached-profiler (PR #3358)

fabpot · fabpot · commit 2b384bb461b5 · 2012-02-15T10:59:57.000+01:00
Commits ------- 57968f8 [HttpKernel] Fix call to Memcached::set() in MemcachedProfilerStorage Discussion ---------- [HttpKernel] Fix call to Memcached::set() in MemcachedProfilerStorage The existing code seems to have been copied from MemcacheProfilerStorage. Memcache::set() includes a $flag argument, but Memcached::set() omits that. See: * http://php.net/manual/en/memcached.set.php * http://php.net/manual/en/memcache.set.php ---- I assume Travis-CI didn't catch the MemcachedProfilerStorageTest failures because those tests are skipped: http://travis-ci.org/#!/symfony/symfony/jobs/678889/L104
diff --git a/src/Symfony/Component/HttpKernel/Profiler/MemcachedProfilerStorage.php b/src/Symfony/Component/HttpKernel/Profiler/MemcachedProfilerStorage.php
@@ -67,7 +67,7 @@ protected function getValue($key)
      */
     protected function setValue($key, $value, $expiration = 0)
     {
-        return $this->getMemcached()->set($key, $value, false, $expiration);
+        return $this->getMemcached()->set($key, $value, $expiration);
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@ protected function getValue($key)`
`67`	`67`	`*/`
`68`	`68`	`protected function setValue($key, $value, $expiration = 0)`
`69`	`69`	`{`
`70`		`- return $this->getMemcached()->set($key, $value, false, $expiration);`
	`70`	`+ return $this->getMemcached()->set($key, $value, $expiration);`
`71`	`71`	`}`
`72`	`72`
`73`	`73`	`/**`