minor #19779 [FrameworkBundle] Fix test scanning the full tmp directory (chalasr)

fabpot · fabpot · commit 2bc54e08630e · 2016-08-30T10:58:27.000-07:00
This PR was merged into the 3.2-dev branch. Discussion ---------- [FrameworkBundle] Fix test scanning the full tmp directory | Q | A | ------------- | --- | Branch? | master | Tests pass? | yes/no | Fixed tickets | n/a | License | MIT Next to #19777 (my bad for both ☺️ ). @nicolas-grekas It seems there are [some similar ones](https://github.com/search?utf8=%E2%9C%93&q=tempnam%28sys_get_temp_dir%28%29%2C+repo%3Asymfony%2Fsymfony&type=Code&ref=searchresults) that need to be fixed Commits ------- bb9413b [FrameworkBundle] Fix test scanning the full tmp directory
diff --git a/src/Symfony/Component/Yaml/Tests/Command/LintCommandTest.php b/src/Symfony/Component/Yaml/Tests/Command/LintCommandTest.php
@@ -67,7 +67,7 @@ public function testLintFileNotReadable()
      */
     private function createFile($content)
     {
-        $filename = tempnam(sys_get_temp_dir(), 'sf-');
+        $filename = tempnam(sys_get_temp_dir().'/framework-yml-lint-test', 'sf-');
         file_put_contents($filename, $content);
 
         $this->files[] = $filename;
@@ -90,6 +90,7 @@ protected function createCommandTester()
     protected function setUp()
     {
         $this->files = array();
+        @mkdir(sys_get_temp_dir().'/framework-yml-lint-test');
     }
 
     protected function tearDown()
@@ -99,5 +100,7 @@ protected function tearDown()
                 unlink($file);
             }
         }
+
+        rmdir(sys_get_temp_dir().'/framework-yml-lint-test');
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@ public function testLintFileNotReadable()`
`67`	`67`	`*/`
`68`	`68`	`private function createFile($content)`
`69`	`69`	`{`
`70`		`- $filename = tempnam(sys_get_temp_dir(), 'sf-');`
	`70`	`+ $filename = tempnam(sys_get_temp_dir().'/framework-yml-lint-test', 'sf-');`
`71`	`71`	`file_put_contents($filename, $content);`
`72`	`72`
`73`	`73`	`$this->files[] = $filename;`
`@@ -90,6 +90,7 @@ protected function createCommandTester()`
`90`	`90`	`protected function setUp()`
`91`	`91`	`{`
`92`	`92`	`$this->files = array();`
	`93`	`+ @mkdir(sys_get_temp_dir().'/framework-yml-lint-test');`
`93`	`94`	`}`
`94`	`95`
`95`	`96`	`protected function tearDown()`
`@@ -99,5 +100,7 @@ protected function tearDown()`
`99`	`100`	`unlink($file);`
`100`	`101`	`}`
`101`	`102`	`}`
	`103`	`+`
	`104`	`+ rmdir(sys_get_temp_dir().'/framework-yml-lint-test');`
`102`	`105`	`}`
`103`	`106`	`}`