minor #41431 [Yaml] Leverage array_is_list() (nicolas-grekas)

nicolas-grekas · nicolas-grekas · commit 2fe4442a1a28 · 2021-06-02T12:07:37.000+02:00
This PR was merged into the 5.4 branch. Discussion ---------- [Yaml] Leverage array_is_list() | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Commits ------- f4da7e4 [Yaml] Leverage array_is_list()
diff --git a/src/Symfony/Component/Yaml/Inline.php b/src/Symfony/Component/Yaml/Inline.php
@@ -207,19 +207,7 @@ public static function dump($value, int $flags = 0): string
      */
     public static function isHash($value): bool
     {
-        if ($value instanceof \stdClass || $value instanceof \ArrayObject) {
-            return true;
-        }
-
-        $expectedKey = 0;
-
-        foreach ($value as $key => $val) {
-            if ($key !== $expectedKey++) {
-                return true;
-            }
-        }
-
-        return false;
+        return !\is_array($value) || !array_is_list($value);
     }
 
     /**
diff --git a/src/Symfony/Component/Yaml/composer.json b/src/Symfony/Component/Yaml/composer.json
@@ -18,7 +18,8 @@
     "require": {
         "php": ">=7.2.5",
         "symfony/deprecation-contracts": "^2.1",
-        "symfony/polyfill-ctype": "~1.8"
+        "symfony/polyfill-ctype": "^1.8",
+        "symfony/polyfill-php81": "^1.22"
     },
     "require-dev": {
         "symfony/console": "^4.4|^5.0|^6.0"
