Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit 3410779

Browse files
committed
[Form] Use strict comparison assertions in tests
Use assertSame instead of assertEquals in some ChoiceTypeTest methods which test placeholder/empty_value options, because the tested value may be any number of "falsey" values.
1 parent d222bd3 commit 3410779

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/Symfony/Component/Form/Tests/Extension/Core/Type/ChoiceTypeTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1637,7 +1637,7 @@ public function testPassPlaceholderToView($multiple, $expanded, $required, $plac
16371637
));
16381638
$view = $form->createView();
16391639

1640-
$this->assertEquals($viewValue, $view->vars['placeholder']);
1640+
$this->assertSame($viewValue, $view->vars['placeholder']);
16411641
$this->assertFalse($view->vars['placeholder_in_choices']);
16421642
}
16431643

@@ -1657,9 +1657,9 @@ public function testPassEmptyValueBC($multiple, $expanded, $required, $placehold
16571657
));
16581658
$view = $form->createView();
16591659

1660-
$this->assertEquals($viewValue, $view->vars['placeholder']);
1660+
$this->assertSame($viewValue, $view->vars['placeholder']);
16611661
$this->assertFalse($view->vars['placeholder_in_choices']);
1662-
$this->assertEquals($viewValue, $view->vars['empty_value']);
1662+
$this->assertSame($viewValue, $view->vars['empty_value']);
16631663
$this->assertFalse($view->vars['empty_value_in_choices']);
16641664
}
16651665

0 commit comments

Comments
 (0)