feature #25928 [DI] Allow binary values in parameters. (bburnichon)

fabpot · fabpot · commit 3424cc7ee67f · 2018-03-27T14:07:18.000+02:00
This PR was squashed before being merged into the 4.1-dev branch (closes #25928). Discussion ---------- [DI] Allow binary values in parameters. | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #25916 | License | MIT | Doc PR | none yet This adds `binary` type in container xsd definition file Commits ------- cb23134 [DI] Allow binary values in parameters.
diff --git a/src/Symfony/Component/DependencyInjection/Dumper/XmlDumper.php b/src/Symfony/Component/DependencyInjection/Dumper/XmlDumper.php
@@ -298,6 +298,10 @@ private function convertParameters(array $parameters, $type, \DOMElement $parent
                 $element->setAttribute('type', 'expression');
                 $text = $this->document->createTextNode(self::phpToXml((string) $value));
                 $element->appendChild($text);
+            } elseif (\is_string($value) && !preg_match('/^[^\x00-\x08\x0B\x0E-\x1A\x1C-\x1F\x7F]*+$/u', $value)) {
+                $element->setAttribute('type', 'binary');
+                $text = $this->document->createTextNode(self::phpToXml(base64_encode($value)));
+                $element->appendChild($text);
             } else {
                 if (in_array($value, array('null', 'true', 'false'), true)) {
                     $element->setAttribute('type', 'string');
diff --git a/src/Symfony/Component/DependencyInjection/Loader/XmlFileLoader.php b/src/Symfony/Component/DependencyInjection/Loader/XmlFileLoader.php
@@ -511,6 +511,12 @@ private function getArgumentsAsPhp(\DOMElement $node, $name, $file, $lowercase =
                     }
                     $arguments[$key] = new TaggedIteratorArgument($arg->getAttribute('tag'));
                     break;
+                case 'binary':
+                    if (false === $value = base64_decode($arg->nodeValue)) {
+                        throw new InvalidArgumentException(sprintf('Tag "<%s>" with type="binary" is not a valid base64 encoded string.', $name));
+                    }
+                    $arguments[$key] = $value;
+                    break;
                 case 'string':
                     $arguments[$key] = $arg->nodeValue;
                     break;
diff --git a/src/Symfony/Component/DependencyInjection/Loader/schema/dic/services/services-1.0.xsd b/src/Symfony/Component/DependencyInjection/Loader/schema/dic/services/services-1.0.xsd
@@ -246,6 +246,7 @@
       <xsd:enumeration value="collection" />
       <xsd:enumeration value="string" />
       <xsd:enumeration value="constant" />
+      <xsd:enumeration value="binary" />
     </xsd:restriction>
   </xsd:simpleType>
 
diff --git a/src/Symfony/Component/DependencyInjection/Tests/Fixtures/containers/container8.php b/src/Symfony/Component/DependencyInjection/Tests/Fixtures/containers/container8.php
@@ -9,6 +9,8 @@
     'bar' => 'foo is %%foo bar',
     'escape' => '@escapeme',
     'values' => array(true, false, null, 0, 1000.3, 'true', 'false', 'null'),
+    'binary' => "\xf0\xf0\xf0\xf0",
+    'binary-control-char' => "This is a Bell char \x07",
 )));
 
 return $container;
diff --git a/src/Symfony/Component/DependencyInjection/Tests/Fixtures/php/services8.php b/src/Symfony/Component/DependencyInjection/Tests/Fixtures/php/services8.php
@@ -135,6 +135,8 @@ protected function getDefaultParameters()
                 6 => 'false',
                 7 => 'null',
             ),
+            'binary' => '����',
+            'binary-control-char' => 'This is a Bell char ',
         );
     }
 }
diff --git a/src/Symfony/Component/DependencyInjection/Tests/Fixtures/xml/services8.xml b/src/Symfony/Component/DependencyInjection/Tests/Fixtures/xml/services8.xml
@@ -18,6 +18,8 @@
       <parameter type="string">false</parameter>
       <parameter type="string">null</parameter>
     </parameter>
+    <parameter key="binary" type="binary">8PDw8A==</parameter>
+    <parameter key="binary-control-char" type="binary">VGhpcyBpcyBhIEJlbGwgY2hhciAH</parameter>
   </parameters>
   <services>
     <service id="service_container" class="Symfony\Component\DependencyInjection\ContainerInterface" public="true" synthetic="true"/>
diff --git a/src/Symfony/Component/DependencyInjection/Tests/Fixtures/yaml/services8.yml b/src/Symfony/Component/DependencyInjection/Tests/Fixtures/yaml/services8.yml
@@ -4,6 +4,8 @@ parameters:
     bar: 'foo is %%foo bar'
     escape: '@@escapeme'
     values: [true, false, null, 0, 1000.3, 'true', 'false', 'null']
+    binary: !!binary 8PDw8A==
+    binary-control-char: !!binary VGhpcyBpcyBhIEJlbGwgY2hhciAH
 
 services:
     service_container:

Original file line number	Diff line number	Diff line change
`@@ -135,6 +135,8 @@ protected function getDefaultParameters()`
`135`	`135`	`6 => 'false',`
`136`	`136`	`7 => 'null',`
`137`	`137`	`),`
	`138`	`+ 'binary' => 'ðððð',`
	`139`	`+ 'binary-control-char' => 'This is a Bell char ',`
`138`	`140`	`);`
`139`	`141`	`}`
`140`	`142`	`}`