Keep BC by using func_get_arg

chalasr · chalasr · commit 35131b9b5df5 · 2016-06-06T21:46:06.000+02:00
Document param (commented)

Fabbot fixes
diff --git a/src/Symfony/Component/PropertyAccess/PropertyAccess.php b/src/Symfony/Component/PropertyAccess/PropertyAccess.php
@@ -21,25 +21,36 @@ final class PropertyAccess
     /**
      * Creates a property accessor with the default configuration.
      *
-     * @param bool $throwExceptionOnInvalidIndex
+     * @param bool $throwExceptionOnInvalidIndex Will be added to the signature in 4.0
      *
      * @return PropertyAccessor The new property accessor
      */
-    public static function createPropertyAccessor($throwExceptionOnInvalidIndex = false)
+    public static function createPropertyAccessor(/* $throwExceptionOnInvalidIndex = false */)
     {
+        $throwExceptionOnInvalidIndex = false;
+
+        if (func_num_args()) {
+            $throwExceptionOnInvalidIndex = func_get_arg(0);
+        }
+
         return self::createPropertyAccessorBuilder($throwExceptionOnInvalidIndex)->getPropertyAccessor();
     }
 
     /**
      * Creates a property accessor builder.
      *
-     * @param bool $enableExceptionOnInvalidIndex
+     * @param bool $enableExceptionOnInvalidIndex Will be added to the signature in 4.0.
      *
      * @return PropertyAccessorBuilder The new property accessor builder
      */
-    public static function createPropertyAccessorBuilder($enableExceptionOnInvalidIndex = false)
+    public static function createPropertyAccessorBuilder(/* $enableExceptionOnInvalidIndex = false */)
     {
         $propertyAccessorBuilder = new PropertyAccessorBuilder();
+        $enableExceptionOnInvalidIndex = false;
+
+        if (func_num_args()) {
+            $enableExceptionOnInvalidIndex = func_get_arg(0);
+        }
 
         if ($enableExceptionOnInvalidIndex) {
             $propertyAccessorBuilder->enableExceptionOnInvalidIndex();

Original file line number	Diff line number	Diff line change
`@@ -21,25 +21,36 @@ final class PropertyAccess`
`21`	`21`	`/**`
`22`	`22`	`* Creates a property accessor with the default configuration.`
`23`	`23`	`*`
`24`		`- * @param bool $throwExceptionOnInvalidIndex`
	`24`	`+ * @param bool $throwExceptionOnInvalidIndex Will be added to the signature in 4.0`
`25`	`25`	`*`
`26`	`26`	`* @return PropertyAccessor The new property accessor`
`27`	`27`	`*/`
`28`		`- public static function createPropertyAccessor($throwExceptionOnInvalidIndex = false)`
	`28`	`+ public static function createPropertyAccessor(/* $throwExceptionOnInvalidIndex = false */)`
`29`	`29`	`{`
	`30`	`+ $throwExceptionOnInvalidIndex = false;`
	`31`	`+`
	`32`	`+ if (func_num_args()) {`
	`33`	`+ $throwExceptionOnInvalidIndex = func_get_arg(0);`
	`34`	`+ }`
	`35`	`+`
`30`	`36`	`return self::createPropertyAccessorBuilder($throwExceptionOnInvalidIndex)->getPropertyAccessor();`
`31`	`37`	`}`
`32`	`38`
`33`	`39`	`/**`
`34`	`40`	`* Creates a property accessor builder.`
`35`	`41`	`*`
`36`		`- * @param bool $enableExceptionOnInvalidIndex`
	`42`	`+ * @param bool $enableExceptionOnInvalidIndex Will be added to the signature in 4.0.`
`37`	`43`	`*`
`38`	`44`	`* @return PropertyAccessorBuilder The new property accessor builder`
`39`	`45`	`*/`
`40`		`- public static function createPropertyAccessorBuilder($enableExceptionOnInvalidIndex = false)`
	`46`	`+ public static function createPropertyAccessorBuilder(/* $enableExceptionOnInvalidIndex = false */)`
`41`	`47`	`{`
`42`	`48`	`$propertyAccessorBuilder = new PropertyAccessorBuilder();`
	`49`	`+ $enableExceptionOnInvalidIndex = false;`
	`50`	`+`
	`51`	`+ if (func_num_args()) {`
	`52`	`+ $enableExceptionOnInvalidIndex = func_get_arg(0);`
	`53`	`+ }`
`43`	`54`
`44`	`55`	`if ($enableExceptionOnInvalidIndex) {`
`45`	`56`	`$propertyAccessorBuilder->enableExceptionOnInvalidIndex();`