Bug #16343 [Router] Too many Routes ?

Jelte Steijaert · Jelte Steijaert · commit 35dfe3e6121e · 2015-11-05T15:51:39.000+01:00
diff --git a/src/Symfony/Component/Routing/Generator/Dumper/PhpGeneratorDumper.php b/src/Symfony/Component/Routing/Generator/Dumper/PhpGeneratorDumper.php
@@ -53,7 +53,7 @@ public function dump(array $options = array())
  */
 class {$options['class']} extends {$options['base_class']}
 {
-    private static \$declaredRoutes = {$this->generateDeclaredRoutes()};
+    private static \$declaredRoutes;
 
     /**
      * Constructor.
@@ -62,6 +62,9 @@ public function __construct(RequestContext \$context, LoggerInterface \$logger =
     {
         \$this->context = \$context;
         \$this->logger = \$logger;
+        if (null === self::\$declaredRoutes) {
+            self::\$declaredRoutes = {$this->generateDeclaredRoutes()};
+        }
     }
 
 {$this->generateGenerateMethod()}
diff --git a/src/Symfony/Component/Routing/Tests/Generator/Dumper/PhpGeneratorDumperTest.php b/src/Symfony/Component/Routing/Tests/Generator/Dumper/PhpGeneratorDumperTest.php
@@ -34,14 +34,21 @@ class PhpGeneratorDumperTest extends \PHPUnit_Framework_TestCase
      */
     private $testTmpFilepath;
 
+    /**
+     * @var string
+     */
+    private $largeTestTmpFilepath;
+
     protected function setUp()
     {
         parent::setUp();
 
         $this->routeCollection = new RouteCollection();
         $this->generatorDumper = new PhpGeneratorDumper($this->routeCollection);
         $this->testTmpFilepath = sys_get_temp_dir().DIRECTORY_SEPARATOR.'php_generator.'.$this->getName().'.php';
+        $this->largeTestTmpFilepath = sys_get_temp_dir().DIRECTORY_SEPARATOR.'php_generator.'.$this->getName().'.large.php';
         @unlink($this->testTmpFilepath);
+        @unlink($this->largeTestTmpFilepath);
     }
 
     protected function tearDown()
@@ -76,6 +83,33 @@ public function testDumpWithRoutes()
         $this->assertEquals($relativeUrlWithoutParameter, '/app.php/testing2');
     }
 
+    public function testDumpWithTooManyRoutes()
+    {
+        $this->routeCollection->add('Test', new Route('/testing/{foo}'));
+        for ( $i = 0; $i < 32769; ++$i ) {
+            $this->routeCollection->add('route_'.$i, new Route('/route_'.$i));
+        }
+        $this->routeCollection->add('Test2', new Route('/testing2'));
+
+        $data = $this->generatorDumper->dump(array(
+            'class' => 'ProjectLargeUrlGenerator',
+        ));
+        file_put_contents($this->largeTestTmpFilepath, $data);
+        include $this->largeTestTmpFilepath;
+
+        $projectUrlGenerator = new \ProjectLargeUrlGenerator(new RequestContext('/app.php'));
+
+        $absoluteUrlWithParameter = $projectUrlGenerator->generate('Test', array('foo' => 'bar'), UrlGeneratorInterface::ABSOLUTE_URL);
+        $absoluteUrlWithoutParameter = $projectUrlGenerator->generate('Test2', array(), UrlGeneratorInterface::ABSOLUTE_URL);
+        $relativeUrlWithParameter = $projectUrlGenerator->generate('Test', array('foo' => 'bar'), UrlGeneratorInterface::ABSOLUTE_PATH);
+        $relativeUrlWithoutParameter = $projectUrlGenerator->generate('Test2', array(), UrlGeneratorInterface::ABSOLUTE_PATH);
+
+        $this->assertEquals($absoluteUrlWithParameter, 'http://localhost/app.php/testing/bar');
+        $this->assertEquals($absoluteUrlWithoutParameter, 'http://localhost/app.php/testing2');
+        $this->assertEquals($relativeUrlWithParameter, '/app.php/testing/bar');
+        $this->assertEquals($relativeUrlWithoutParameter, '/app.php/testing2');
+    }
+
     /**
      * @expectedException \InvalidArgumentException
      */

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ public function dump(array $options = array())`
`53`	`53`	`*/`
`54`	`54`	`class {$options['class']} extends {$options['base_class']}`
`55`	`55`	`{`
`56`		`- private static \$declaredRoutes = {$this->generateDeclaredRoutes()};`
	`56`	`+ private static \$declaredRoutes;`
`57`	`57`
`58`	`58`	`/**`
`59`	`59`	`* Constructor.`
`@@ -62,6 +62,9 @@ public function __construct(RequestContext \$context, LoggerInterface \$logger =`
`62`	`62`	`{`
`63`	`63`	`\$this->context = \$context;`
`64`	`64`	`\$this->logger = \$logger;`
	`65`	`+ if (null === self::\$declaredRoutes) {`
	`66`	`+ self::\$declaredRoutes = {$this->generateDeclaredRoutes()};`
	`67`	`+ }`
`65`	`68`	`}`
`66`	`69`
`67`	`70`	`{$this->generateGenerateMethod()}`