bug #44131 [Yaml] properly parse quoted strings tagged with !!str (xabbuh)

xabbuh · xabbuh · commit 38f3c1209307 · 2021-11-19T11:02:36.000+01:00
This PR was merged into the 4.4 branch. Discussion ---------- [Yaml] properly parse quoted strings tagged with !!str | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #44019 | License | MIT | Doc PR | Commits ------- 1e7e7e0 properly parse quoted strings tagged with !!str
diff --git a/src/Symfony/Component/Yaml/Inline.php b/src/Symfony/Component/Yaml/Inline.php
@@ -269,10 +269,11 @@ private static function dumpNull(int $flags): string
      *
      * @throws ParseException When malformed inline YAML string is parsed
      */
-    public static function parseScalar(string $scalar, int $flags = 0, array $delimiters = null, int &$i = 0, bool $evaluate = true, array &$references = [])
+    public static function parseScalar(string $scalar, int $flags = 0, array $delimiters = null, int &$i = 0, bool $evaluate = true, array &$references = [], bool &$isQuoted = null)
     {
         if (\in_array($scalar[$i], ['"', "'"])) {
             // quoted scalar
+            $isQuoted = true;
             $output = self::parseQuotedScalar($scalar, $i);
 
             if (null !== $delimiters) {
@@ -286,6 +287,8 @@ public static function parseScalar(string $scalar, int $flags = 0, array $delimi
             }
         } else {
             // "normal" string
+            $isQuoted = false;
+
             if (!$delimiters) {
                 $output = substr($scalar, $i);
                 $i += \strlen($output);
@@ -308,7 +311,7 @@ public static function parseScalar(string $scalar, int $flags = 0, array $delimi
             }
 
             if ($evaluate) {
-                $output = self::evaluateScalar($output, $flags, $references);
+                $output = self::evaluateScalar($output, $flags, $references, $isQuoted);
             }
         }
 
@@ -320,7 +323,7 @@ public static function parseScalar(string $scalar, int $flags = 0, array $delimi
      *
      * @throws ParseException When malformed inline YAML string is parsed
      */
-    private static function parseQuotedScalar(string $scalar, int &$i): string
+    private static function parseQuotedScalar(string $scalar, int &$i = 0): string
     {
         if (!Parser::preg_match('/'.self::REGEX_QUOTED_STRING.'/Au', substr($scalar, $i), $match)) {
             throw new ParseException(sprintf('Malformed inline YAML string: "%s".', substr($scalar, $i)), self::$parsedLineNumber + 1, $scalar, self::$parsedFilename);
@@ -373,8 +376,7 @@ private static function parseSequence(string $sequence, int $flags, int &$i = 0,
                     $value = self::parseMapping($sequence, $flags, $i, $references);
                     break;
                 default:
-                    $isQuoted = \in_array($sequence[$i], ['"', "'"]);
-                    $value = self::parseScalar($sequence, $flags, [',', ']'], $i, null === $tag, $references);
+                    $value = self::parseScalar($sequence, $flags, [',', ']'], $i, null === $tag, $references, $isQuoted);
 
                     // the value can be an array if a reference has been resolved to an array var
                     if (\is_string($value) && !$isQuoted && false !== strpos($value, ': ')) {
@@ -521,8 +523,7 @@ private static function parseMapping(string $mapping, int $flags, int &$i = 0, a
                         }
                         break;
                     default:
-                        $isValueQuoted = \in_array($mapping[$i], ['"', "'"]);
-                        $value = self::parseScalar($mapping, $flags, [',', '}', "\n"], $i, null === $tag, $references);
+                        $value = self::parseScalar($mapping, $flags, [',', '}', "\n"], $i, null === $tag, $references, $isValueQuoted);
                         // Spec: Keys MUST be unique; first one wins.
                         // Parser cannot abort this mapping earlier, since lines
                         // are processed sequentially.
@@ -561,8 +562,9 @@ private static function parseMapping(string $mapping, int $flags, int &$i = 0, a
      *
      * @throws ParseException when object parsing support was disabled and the parser detected a PHP object or when a reference could not be resolved
      */
-    private static function evaluateScalar(string $scalar, int $flags, array &$references = [])
+    private static function evaluateScalar(string $scalar, int $flags, array &$references = [], bool &$isQuotedString = null)
     {
+        $isQuotedString = false;
         $scalar = trim($scalar);
         $scalarLower = strtolower($scalar);
 
@@ -597,7 +599,14 @@ private static function evaluateScalar(string $scalar, int $flags, array &$refer
             case '!' === $scalar[0]:
                 switch (true) {
                     case 0 === strpos($scalar, '!!str '):
-                        return (string) substr($scalar, 6);
+                        $s = (string) substr($scalar, 6);
+
+                        if (\in_array($s[0] ?? '', ['"', "'"], true)) {
+                            $isQuotedString = true;
+                            $s = self::parseQuotedScalar($s);
+                        }
+
+                        return $s;
                     case 0 === strpos($scalar, '! '):
                         return substr($scalar, 2);
                     case 0 === strpos($scalar, '!php/object'):
diff --git a/src/Symfony/Component/Yaml/Tests/InlineTest.php b/src/Symfony/Component/Yaml/Tests/InlineTest.php
@@ -906,21 +906,31 @@ public function ideographicSpaceProvider(): array
         ];
     }
 
+    public function testParseSingleQuotedTaggedString()
+    {
+        $this->assertSame('foo', Inline::parse("!!str 'foo'"));
+    }
+
+    public function testParseDoubleQuotedTaggedString()
+    {
+        $this->assertSame('foo', Inline::parse('!!str "foo"'));
+    }
+
     public function testParseQuotedReferenceLikeStringsInMapping()
     {
         $yaml = <<<YAML
-{foo: '&foo', bar: "&bar"}
+{foo: '&foo', bar: "&bar", baz: !!str '&baz'}
 YAML;
 
-        $this->assertSame(['foo' => '&foo', 'bar' => '&bar'], Inline::parse($yaml));
+        $this->assertSame(['foo' => '&foo', 'bar' => '&bar', 'baz' => '&baz'], Inline::parse($yaml));
     }
 
     public function testParseQuotedReferenceLikeStringsInSequence()
     {
         $yaml = <<<YAML
-['&foo', "&bar" ]
+['&foo', "&bar", !!str '&baz']
 YAML;
 
-        $this->assertSame(['&foo', '&bar'], Inline::parse($yaml));
+        $this->assertSame(['&foo', '&bar', '&baz'], Inline::parse($yaml));
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -906,21 +906,31 @@ public function ideographicSpaceProvider(): array`
`906`	`906`	`];`
`907`	`907`	`}`
`908`	`908`
	`909`	`+ public function testParseSingleQuotedTaggedString()`
	`910`	`+ {`
	`911`	`+ $this->assertSame('foo', Inline::parse("!!str 'foo'"));`
	`912`	`+ }`
	`913`	`+`
	`914`	`+ public function testParseDoubleQuotedTaggedString()`
	`915`	`+ {`
	`916`	`+ $this->assertSame('foo', Inline::parse('!!str "foo"'));`
	`917`	`+ }`
	`918`	`+`
`909`	`919`	`public function testParseQuotedReferenceLikeStringsInMapping()`
`910`	`920`	`{`
`911`	`921`	`$yaml = <<<YAML`
`912`		`-{foo: '&foo', bar: "&bar"}`
	`922`	`+{foo: '&foo', bar: "&bar", baz: !!str '&baz'}`
`913`	`923`	`YAML;`
`914`	`924`
`915`		`- $this->assertSame(['foo' => '&foo', 'bar' => '&bar'], Inline::parse($yaml));`
	`925`	`+ $this->assertSame(['foo' => '&foo', 'bar' => '&bar', 'baz' => '&baz'], Inline::parse($yaml));`
`916`	`926`	`}`
`917`	`927`
`918`	`928`	`public function testParseQuotedReferenceLikeStringsInSequence()`
`919`	`929`	`{`
`920`	`930`	`$yaml = <<<YAML`
`921`		`-['&foo', "&bar" ]`
	`931`	`+['&foo', "&bar", !!str '&baz']`
`922`	`932`	`YAML;`
`923`	`933`
`924`		`- $this->assertSame(['&foo', '&bar'], Inline::parse($yaml));`
	`934`	`+ $this->assertSame(['&foo', '&bar', '&baz'], Inline::parse($yaml));`
`925`	`935`	`}`
`926`	`936`	`}`