[WebserverBundle] Deprecate the bundle in favor of symfony local server

Simperfit · Simperfit · commit 396cc5e115c0 · 2019-05-18T07:51:14.000+02:00
diff --git a/src/Symfony/Bundle/WebServerBundle/Command/ServerLogCommand.php b/src/Symfony/Bundle/WebServerBundle/Command/ServerLogCommand.php
@@ -24,6 +24,8 @@
 
 /**
  * @author Grégoire Pineau <lyrixx@lyrixx.info>
+ *
+ * @deprecated since version 4.4, to be removed in 5.0; the new symfony local server has more feature, you should use it instead.
  */
 class ServerLogCommand extends Command
 {
@@ -77,6 +79,8 @@ protected function configure()
 
     protected function execute(InputInterface $input, OutputInterface $output)
     {
+        @trigger_error('Using the WebserverBundle is deprecated since 4.4. The new symfony local server has more feature, you should use it instead.', E_USER_DEPRECATED);
+
         $filter = $input->getOption('filter');
         if ($filter) {
             if (!class_exists(ExpressionLanguage::class)) {
diff --git a/src/Symfony/Bundle/WebServerBundle/Command/ServerRunCommand.php b/src/Symfony/Bundle/WebServerBundle/Command/ServerRunCommand.php
@@ -26,6 +26,8 @@
  * Runs Symfony application using a local web server.
  *
  * @author Michał Pipa <michal.pipa.xsolve@gmail.com>
+ *
+ * @deprecated since version 4.4, to be removed in 5.0; the new symfony local server has more feature, you should use it instead.
  */
 class ServerRunCommand extends Command
 {
@@ -90,6 +92,8 @@ protected function configure()
      */
     protected function execute(InputInterface $input, OutputInterface $output)
     {
+        @trigger_error('Using the WebserverBundle is deprecated since 4.4. The new symfony local server has more feature, you should use it instead.', E_USER_DEPRECATED);
+
         $io = new SymfonyStyle($input, $output instanceof ConsoleOutputInterface ? $output->getErrorOutput() : $output);
 
         if (null === $documentRoot = $input->getOption('docroot')) {
diff --git a/src/Symfony/Bundle/WebServerBundle/Command/ServerStartCommand.php b/src/Symfony/Bundle/WebServerBundle/Command/ServerStartCommand.php
@@ -26,6 +26,8 @@
  * Runs a local web server in a background process.
  *
  * @author Christian Flothmann <christian.flothmann@xabbuh.de>
+ *
+ * @deprecated since version 4.4, to be removed in 5.0; the new symfony local server has more feature, you should use it instead.
  */
 class ServerStartCommand extends Command
 {
@@ -90,6 +92,8 @@ protected function configure()
      */
     protected function execute(InputInterface $input, OutputInterface $output)
     {
+        @trigger_error('Using the WebserverBundle is deprecated since 4.4. The new symfony local server has more feature, you should use it instead.', E_USER_DEPRECATED);
+
         $io = new SymfonyStyle($input, $output instanceof ConsoleOutputInterface ? $output->getErrorOutput() : $output);
 
         if (!\extension_loaded('pcntl')) {
diff --git a/src/Symfony/Bundle/WebServerBundle/Command/ServerStatusCommand.php b/src/Symfony/Bundle/WebServerBundle/Command/ServerStatusCommand.php
@@ -25,6 +25,8 @@
  * the background.
  *
  * @author Christian Flothmann <christian.flothmann@xabbuh.de>
+ *
+ * @deprecated since version 4.4, to be removed in 5.0; the new symfony local server has more feature, you should use it instead.
  */
 class ServerStatusCommand extends Command
 {
@@ -72,6 +74,8 @@ protected function configure()
      */
     protected function execute(InputInterface $input, OutputInterface $output)
     {
+        @trigger_error('Using the WebserverBundle is deprecated since 4.4. The new symfony local server has more feature, you should use it instead.', E_USER_DEPRECATED);
+
         $io = new SymfonyStyle($input, $output instanceof ConsoleOutputInterface ? $output->getErrorOutput() : $output);
         $server = new WebServer($this->pidFileDirectory);
         if ($filter = $input->getOption('filter')) {
diff --git a/src/Symfony/Bundle/WebServerBundle/Command/ServerStopCommand.php b/src/Symfony/Bundle/WebServerBundle/Command/ServerStopCommand.php
@@ -23,6 +23,8 @@
  * Stops a background process running a local web server.
  *
  * @author Christian Flothmann <christian.flothmann@xabbuh.de>
+ *
+ * @deprecated since version 4.4, to be removed in 5.0; the new symfony local server has more feature, you should use it instead.
  */
 class ServerStopCommand extends Command
 {
@@ -61,6 +63,8 @@ protected function configure()
      */
     protected function execute(InputInterface $input, OutputInterface $output)
     {
+        @trigger_error('Using the WebserverBundle is deprecated since 4.4. The new symfony local server has more feature, you should use it instead.', E_USER_DEPRECATED);
+
         $io = new SymfonyStyle($input, $output instanceof ConsoleOutputInterface ? $output->getErrorOutput() : $output);
 
         try {
diff --git a/src/Symfony/Bundle/WebServerBundle/DependencyInjection/WebServerExtension.php b/src/Symfony/Bundle/WebServerBundle/DependencyInjection/WebServerExtension.php
@@ -19,6 +19,8 @@
 
 /**
  * @author Robin Chalas <robin.chalas@gmail.com>
+ *
+ * @deprecated since version 4.4, to be removed in 5.0; the new symfony local server has more feature, you should use it instead.
  */
 class WebServerExtension extends Extension
 {
@@ -40,6 +42,8 @@ public function load(array $configs, ContainerBuilder $container)
         if (!class_exists(ConsoleFormatter::class)) {
             $container->removeDefinition('web_server.command.server_log');
         }
+
+        @trigger_error('Using the WebserverBundle is deprecated since 4.3, the new symfony local server has more feature, you should use it instead.');
     }
 
     private function getPublicDirectory(ContainerBuilder $container)
diff --git a/src/Symfony/Bundle/WebServerBundle/Tests/DependencyInjection/WebServerExtensionTest.php b/src/Symfony/Bundle/WebServerBundle/Tests/DependencyInjection/WebServerExtensionTest.php
@@ -18,6 +18,9 @@
 
 class WebServerExtensionTest extends TestCase
 {
+    /**
+     * @group legacy
+     */
     public function testLoad()
     {
         $container = new ContainerBuilder();
diff --git a/src/Symfony/Bundle/WebServerBundle/WebServer.php b/src/Symfony/Bundle/WebServerBundle/WebServer.php
@@ -19,6 +19,8 @@
  * Manages a local HTTP web server.
  *
  * @author Fabien Potencier <fabien@symfony.com>
+ *
+ * @deprecated since version 4.4, to be removed in 5.0; the new symfony local server has more feature, you should use it instead.
  */
 class WebServer
 {
diff --git a/src/Symfony/Bundle/WebServerBundle/WebServerBundle.php b/src/Symfony/Bundle/WebServerBundle/WebServerBundle.php
@@ -13,6 +13,13 @@
 
 use Symfony\Component\HttpKernel\Bundle\Bundle;
 
+/**
+ * @deprecated since version 4.4, to be removed in 5.0; the new symfony local server has more feature, you should use it instead.
+ */
 class WebServerBundle extends Bundle
 {
+    public function boot()
+    {
+        @trigger_error('Using the WebserverBundle is deprecated since 4.4. The new symfony local server has more feature, you should use it instead.', E_USER_DEPRECATED);
+    }
 }
diff --git a/src/Symfony/Bundle/WebServerBundle/WebServerConfig.php b/src/Symfony/Bundle/WebServerBundle/WebServerConfig.php
@@ -13,6 +13,8 @@
 
 /**
  * @author Fabien Potencier <fabien@symfony.com>
+ *
+ * @deprecated since version 4.4, to be removed in 5.0; the new symfony local server has more feature, you should use it instead.
  */
 class WebServerConfig
 {

Original file line number	Diff line number	Diff line change
`@@ -26,6 +26,8 @@`
`26`	`26`	`* Runs Symfony application using a local web server.`
`27`	`27`	`*`
`28`	`28`	`* @author Michał Pipa <[email protected]>`
	`29`	`+ *`
	`30`	`+ * @deprecated since version 4.4, to be removed in 5.0; the new symfony local server has more feature, you should use it instead.`
`29`	`31`	`*/`
`30`	`32`	`class ServerRunCommand extends Command`
`31`	`33`	`{`
`@@ -90,6 +92,8 @@ protected function configure()`
`90`	`92`	`*/`
`91`	`93`	`protected function execute(InputInterface $input, OutputInterface $output)`
`92`	`94`	`{`
	`95`	`+ @trigger_error('Using the WebserverBundle is deprecated since 4.4. The new symfony local server has more feature, you should use it instead.', E_USER_DEPRECATED);`
	`96`	`+`
`93`	`97`	`$io = new SymfonyStyle($input, $output instanceof ConsoleOutputInterface ? $output->getErrorOutput() : $output);`
`94`	`98`
`95`	`99`	`if (null === $documentRoot = $input->getOption('docroot')) {`
Original file line number	Diff line number	Diff line change
`@@ -25,6 +25,8 @@`
`25`	`25`	`* the background.`
`26`	`26`	`*`
`27`	`27`	`* @author Christian Flothmann <[email protected]>`
	`28`	`+ *`
	`29`	`+ * @deprecated since version 4.4, to be removed in 5.0; the new symfony local server has more feature, you should use it instead.`
`28`	`30`	`*/`
`29`	`31`	`class ServerStatusCommand extends Command`
`30`	`32`	`{`
`@@ -72,6 +74,8 @@ protected function configure()`
`72`	`74`	`*/`
`73`	`75`	`protected function execute(InputInterface $input, OutputInterface $output)`
`74`	`76`	`{`
	`77`	`+ @trigger_error('Using the WebserverBundle is deprecated since 4.4. The new symfony local server has more feature, you should use it instead.', E_USER_DEPRECATED);`
	`78`	`+`
`75`	`79`	`$io = new SymfonyStyle($input, $output instanceof ConsoleOutputInterface ? $output->getErrorOutput() : $output);`
`76`	`80`	`$server = new WebServer($this->pidFileDirectory);`
`77`	`81`	`if ($filter = $input->getOption('filter')) {`
Original file line number	Diff line number	Diff line change
`@@ -23,6 +23,8 @@`
`23`	`23`	`* Stops a background process running a local web server.`
`24`	`24`	`*`
`25`	`25`	`* @author Christian Flothmann <[email protected]>`
	`26`	`+ *`
	`27`	`+ * @deprecated since version 4.4, to be removed in 5.0; the new symfony local server has more feature, you should use it instead.`
`26`	`28`	`*/`
`27`	`29`	`class ServerStopCommand extends Command`
`28`	`30`	`{`
`@@ -61,6 +63,8 @@ protected function configure()`
`61`	`63`	`*/`
`62`	`64`	`protected function execute(InputInterface $input, OutputInterface $output)`
`63`	`65`	`{`
	`66`	`+ @trigger_error('Using the WebserverBundle is deprecated since 4.4. The new symfony local server has more feature, you should use it instead.', E_USER_DEPRECATED);`
	`67`	`+`
`64`	`68`	`$io = new SymfonyStyle($input, $output instanceof ConsoleOutputInterface ? $output->getErrorOutput() : $output);`
`65`	`69`
`66`	`70`	`try {`
Original file line number	Diff line number	Diff line change
`@@ -19,6 +19,8 @@`
`19`	`19`
`20`	`20`	`/**`
`21`	`21`	`* @author Robin Chalas <[email protected]>`
	`22`	`+ *`
	`23`	`+ * @deprecated since version 4.4, to be removed in 5.0; the new symfony local server has more feature, you should use it instead.`
`22`	`24`	`*/`
`23`	`25`	`class WebServerExtension extends Extension`
`24`	`26`	`{`
`@@ -40,6 +42,8 @@ public function load(array $configs, ContainerBuilder $container)`
`40`	`42`	`if (!class_exists(ConsoleFormatter::class)) {`
`41`	`43`	`$container->removeDefinition('web_server.command.server_log');`
`42`	`44`	`}`
	`45`	`+`
	`46`	`+ @trigger_error('Using the WebserverBundle is deprecated since 4.3, the new symfony local server has more feature, you should use it instead.');`
`43`	`47`	`}`
`44`	`48`
`45`	`49`	`private function getPublicDirectory(ContainerBuilder $container)`
Original file line number	Diff line number	Diff line change
`@@ -18,6 +18,9 @@`
`18`	`18`
`19`	`19`	`class WebServerExtensionTest extends TestCase`
`20`	`20`	`{`
	`21`	`+ /**`
	`22`	`+ * @group legacy`
	`23`	`+ */`
`21`	`24`	`public function testLoad()`
`22`	`25`	`{`
`23`	`26`	`$container = new ContainerBuilder();`
Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,13 @@`
`13`	`13`
`14`	`14`	`use Symfony\Component\HttpKernel\Bundle\Bundle;`
`15`	`15`
	`16`	`+/**`
	`17`	`+ * @deprecated since version 4.4, to be removed in 5.0; the new symfony local server has more feature, you should use it instead.`
	`18`	`+ */`
`16`	`19`	`class WebServerBundle extends Bundle`
`17`	`20`	`{`
	`21`	`+ public function boot()`
	`22`	`+ {`
	`23`	`+ @trigger_error('Using the WebserverBundle is deprecated since 4.4. The new symfony local server has more feature, you should use it instead.', E_USER_DEPRECATED);`
	`24`	`+ }`
`18`	`25`	`}`
Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,8 @@`
`13`	`13`
`14`	`14`	`/**`
`15`	`15`	`* @author Fabien Potencier <[email protected]>`
	`16`	`+ *`
	`17`	`+ * @deprecated since version 4.4, to be removed in 5.0; the new symfony local server has more feature, you should use it instead.`
`16`	`18`	`*/`
`17`	`19`	`class WebServerConfig`
`18`	`20`	`{`