bug #52442 Disable the "Copy as cURL" button when the debug info are disabled (stof)

fabpot · fabpot · commit 3e2f2e388c60 · 2023-11-03T19:20:48.000+01:00
This PR was merged into the 6.3 branch. Discussion ---------- Disable the "Copy as cURL" button when the debug info are disabled | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | Fix #52441 | License | MIT Some versions of curl have a bug that prevents collecting the debug info. This is reported by writing an explanation message in the debug buffer. When this is detecting, the "Copy as cURL" button is now skipped (like for other unsupported cases) instead of copying a broken command. Commits ------- f66dd14 Disable the "Copy as cURL" button when the debug info are disabled
diff --git a/src/Symfony/Component/HttpClient/DataCollector/HttpClientDataCollector.php b/src/Symfony/Component/HttpClient/DataCollector/HttpClientDataCollector.php
@@ -230,6 +230,11 @@ private function getCurlCommand(array $trace): ?string
                 break;
             }
 
+            if (str_starts_with('Due to a bug in curl ', $line)) {
+                // When the curl client disables debug info due to a curl bug, we cannot build the command.
+                return null;
+            }
+
             if ('' === $line || preg_match('/^[*<]|(Host: )/', $line)) {
                 continue;
             }

Original file line number	Diff line number	Diff line change
`@@ -230,6 +230,11 @@ private function getCurlCommand(array $trace): ?string`
`230`	`230`	`break;`
`231`	`231`	`}`
`232`	`232`
	`233`	`+ if (str_starts_with('Due to a bug in curl ', $line)) {`
	`234`	`+ // When the curl client disables debug info due to a curl bug, we cannot build the command.`
	`235`	`+ return null;`
	`236`	`+ }`
	`237`	`+`
`233`	`238`	`if ('' === $line \|\| preg_match('/^[*<]\|(Host: )/', $line)) {`
`234`	`239`	`continue;`
`235`	`240`	`}`