minor #26423 [DomCrawler] minor performance improvement (dunglas)

nicolas-grekas · nicolas-grekas · commit 3e999880ed6b · 2018-03-14T17:32:59.000+01:00
This PR was squashed before being merged into the 4.1-dev branch (closes #26423). Discussion ---------- [DomCrawler] minor performance improvement | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no  | BC breaks? | no  | Deprecations? |no  | Tests pass? | yes  | Fixed tickets | n/a  | License | MIT | Doc PR | n/a Commits ------- eead301 [DomCrawler] minor performance improvement
diff --git a/src/Symfony/Component/DomCrawler/Crawler.php b/src/Symfony/Component/DomCrawler/Crawler.php
@@ -1080,8 +1080,9 @@ protected function sibling($node, $siblingDir = 'nextSibling')
     {
         $nodes = array();
 
+        $currentNode = $this->getNode(0);
         do {
-            if ($node !== $this->getNode(0) && 1 === $node->nodeType) {
+            if ($node !== $currentNode && XML_ELEMENT_NODE === $node->nodeType) {
                 $nodes[] = $node;
             }
         } while ($node = $node->$siblingDir);

Original file line number	Diff line number	Diff line change
`@@ -1080,8 +1080,9 @@ protected function sibling($node, $siblingDir = 'nextSibling')`
`1080`	`1080`	`{`
`1081`	`1081`	`$nodes = array();`
`1082`	`1082`
	`1083`	`+ $currentNode = $this->getNode(0);`
`1083`	`1084`	`do {`
`1084`		`- if ($node !== $this->getNode(0) && 1 === $node->nodeType) {`
	`1085`	`+ if ($node !== $currentNode && XML_ELEMENT_NODE === $node->nodeType) {`
`1085`	`1086`	`$nodes[] = $node;`
`1086`	`1087`	`}`
`1087`	`1088`	`} while ($node = $node->$siblingDir);`