bug #26677 Support phpdbg SAPI in Debug::enable() (hkdobrev)

fabpot · fabpot · commit 3faa1d505ade · 2018-03-27T09:04:23.000+02:00
This PR was squashed before being merged into the 2.7 branch (closes #26677). Discussion ---------- Support phpdbg SAPI in Debug::enable() | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no  | BC breaks? | no  | Deprecations? | no  | Tests pass? | yes  | Fixed tickets |  | License | MIT | Doc PR |  PHPDBG is a CLI PHP debugger which could be useful for debugging in development or for running PHPUnit tests with code coverage faster compared to XDebug. It has CLI characteristics, but it runs as a different SAPI. Commits ------- 49a144f Support phpdbg SAPI in Debug::enable()
diff --git a/src/Symfony/Component/Debug/Debug.php b/src/Symfony/Component/Debug/Debug.php
@@ -45,7 +45,7 @@ public static function enable($errorReportingLevel = null, $displayErrors = true
             error_reporting(-1);
         }
 
-        if ('cli' !== PHP_SAPI) {
+        if (!in_array(PHP_SAPI, array('cli', 'phpdbg'))) {
             ini_set('display_errors', 0);
             ExceptionHandler::register();
         } elseif ($displayErrors && (!ini_get('log_errors') || ini_get('error_log'))) {

Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ public static function enable($errorReportingLevel = null, $displayErrors = true`
`45`	`45`	`error_reporting(-1);`
`46`	`46`	`}`
`47`	`47`
`48`		`- if ('cli' !== PHP_SAPI) {`
	`48`	`+ if (!in_array(PHP_SAPI, array('cli', 'phpdbg'))) {`
`49`	`49`	`ini_set('display_errors', 0);`
`50`	`50`	`ExceptionHandler::register();`
`51`	`51`	`} elseif ($displayErrors && (!ini_get('log_errors') \|\| ini_get('error_log'))) {`