[Notifier] [Bridge] Store message id for slack transport's SendMessage

WaylandAce · WaylandAce · commit 3fae7690231e · 2021-04-27T13:27:10.000+03:00
diff --git a/src/Symfony/Component/Notifier/Bridge/Slack/SlackTransport.php b/src/Symfony/Component/Notifier/Bridge/Slack/SlackTransport.php
@@ -91,6 +91,9 @@ protected function doSend(MessageInterface $message): SentMessage
             throw new TransportException(sprintf('Unable to post the Slack message: "%s".', $result['error']), $response);
         }
 
-        return new SentMessage($message, (string) $this);
+        $sentMessage = new SentMessage($message, (string) $this);
+        $sentMessage->setMessageId($result['ts']);
+
+        return $sentMessage;
     }
 }
diff --git a/src/Symfony/Component/Notifier/Bridge/Slack/Tests/SlackTransportTest.php b/src/Symfony/Component/Notifier/Bridge/Slack/Tests/SlackTransportTest.php
@@ -203,4 +203,42 @@ public function testSendWith200ResponseButNotOk()
 
         $transport->send(new ChatMessage('testMessage'));
     }
+
+    public function testMessageIdSet()
+    {
+        $channel = 'testChannel';
+        $message = 'testMessage';
+
+        $response = $this->createMock(ResponseInterface::class);
+
+        $response->expects($this->exactly(2))
+            ->method('getStatusCode')
+            ->willReturn(200);
+
+        $response->expects($this->once())
+            ->method('getContent')
+            ->willReturn(json_encode(['ok' => true, 'ts' => '1503435956.000247']));
+
+        $notification = new Notification($message);
+        $chatMessage = ChatMessage::fromNotification($notification);
+        $options = SlackOptions::fromNotification($notification);
+
+        $expectedBody = json_encode([
+            'blocks' => $options->toArray()['blocks'],
+            'channel' => $channel,
+            'text' => $message,
+        ]);
+
+        $client = new MockHttpClient(function (string $method, string $url, array $options = []) use ($response, $expectedBody): ResponseInterface {
+            $this->assertJsonStringEqualsJsonString($expectedBody, $options['body']);
+
+            return $response;
+        });
+
+        $transport = $this->createTransport($client, $channel);
+
+        $sentMessage = $transport->send($chatMessage);
+
+        $this->assertEquals('1503435956.000247', $sentMessage->getMessageId());
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -91,6 +91,9 @@ protected function doSend(MessageInterface $message): SentMessage`
`91`	`91`	`throw new TransportException(sprintf('Unable to post the Slack message: "%s".', $result['error']), $response);`
`92`	`92`	`}`
`93`	`93`
`94`		`- return new SentMessage($message, (string) $this);`
	`94`	`+ $sentMessage = new SentMessage($message, (string) $this);`
	`95`	`+ $sentMessage->setMessageId($result['ts']);`
	`96`	`+`
	`97`	`+ return $sentMessage;`
`95`	`98`	`}`
`96`	`99`	`}`