minor #41372 [Routing] Remove legacy group from Doctrine Annotations test (derrabus)

derrabus · derrabus · commit 40a6b17edebc · 2021-05-22T21:29:30.000+02:00
This PR was merged into the 5.3 branch. Discussion ---------- [Routing] Remove legacy group from Doctrine Annotations test | Q | A | ------------- | --- | Branch? | 5.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | N/A A test case in `RoutingTest` is incorrectly flagged as legacy. I've removed the legacy group and changed the wording of the test cases to make clear what they're actually testing. Commits ------- 6b8ff65 [Routing] Remove legacy group from Doctrine Annotations test
diff --git a/src/Symfony/Component/Routing/Tests/Annotation/RouteTest.php b/src/Symfony/Component/Routing/Tests/Annotation/RouteTest.php
@@ -74,17 +74,16 @@ public function testDeprecationArrayAsFirstArgument(string $parameter, $value, s
      * @requires PHP 8
      * @dataProvider getValidParameters
      */
-    public function testRouteParameters(string $methodName, string $getter, $expectedReturn)
+    public function testLoadFromAttribute(string $methodName, string $getter, $expectedReturn)
     {
         $route = $this->getMethodAnnotation($methodName, true);
         $this->assertEquals($route->$getter(), $expectedReturn);
     }
 
     /**
-     * @group legacy
      * @dataProvider getValidParameters
      */
-    public function testLegacyRouteParameters(string $methodName, string $getter, $expectedReturn)
+    public function testLoadFromDoctrineAnnotation(string $methodName, string $getter, $expectedReturn)
     {
         $route = $this->getMethodAnnotation($methodName, false);
         $this->assertEquals($route->$getter(), $expectedReturn);

Original file line number	Diff line number	Diff line change
`@@ -74,17 +74,16 @@ public function testDeprecationArrayAsFirstArgument(string $parameter, $value, s`
`74`	`74`	`* @requires PHP 8`
`75`	`75`	`* @dataProvider getValidParameters`
`76`	`76`	`*/`
`77`		`- public function testRouteParameters(string $methodName, string $getter, $expectedReturn)`
	`77`	`+ public function testLoadFromAttribute(string $methodName, string $getter, $expectedReturn)`
`78`	`78`	`{`
`79`	`79`	`$route = $this->getMethodAnnotation($methodName, true);`
`80`	`80`	`$this->assertEquals($route->$getter(), $expectedReturn);`
`81`	`81`	`}`
`82`	`82`
`83`	`83`	`/**`
`84`		`- * @group legacy`
`85`	`84`	`* @dataProvider getValidParameters`
`86`	`85`	`*/`
`87`		`- public function testLegacyRouteParameters(string $methodName, string $getter, $expectedReturn)`
	`86`	`+ public function testLoadFromDoctrineAnnotation(string $methodName, string $getter, $expectedReturn)`
`88`	`87`	`{`
`89`	`88`	`$route = $this->getMethodAnnotation($methodName, false);`
`90`	`89`	`$this->assertEquals($route->$getter(), $expectedReturn);`