Clean Docblocks and and rename Modification => UpdateOperation in one docblock

mablae · mablae · commit 40b19f67e6c7 · 2018-05-13T14:05:53.000+02:00
diff --git a/src/Symfony/Component/Ldap/Adapter/ExtLdap/EntryManager.php b/src/Symfony/Component/Ldap/Adapter/ExtLdap/EntryManager.php
@@ -124,8 +124,7 @@ private function getConnectionResource()
     }
 
     /**
-     * @param string                     $dn         Distinguished name to apply operations on
-     * @param iterable|UpdateOperation[] $operations An array or iterable of Modification instances
+     * @param iterable|UpdateOperation[] $operations An array or iterable of UpdateOperation instances
      *
      * @throws UpdateOperationException in case of an error
      */
@@ -137,7 +136,7 @@ public function applyOperations(string $dn, iterable $operations): void
         }
 
         if (!@ldap_modify_batch($this->getConnectionResource(), $dn, $operationsMapped)) {
-            throw new UpdateOperationException(sprintf('Error executing batch modification on "%s": "%s".', $dn, ldap_error($this->getConnectionResource())));
+            throw new UpdateOperationException(sprintf('Error executing UpdateOperation on "%s": "%s".', $dn, ldap_error($this->getConnectionResource())));
         }
     }
 }
diff --git a/src/Symfony/Component/Ldap/Adapter/ExtLdap/UpdateOperation.php b/src/Symfony/Component/Ldap/Adapter/ExtLdap/UpdateOperation.php
@@ -29,7 +29,6 @@ class UpdateOperation
     /**
      * @param int        $operationType An LDAP_MODIFY_BATCH_* constant
      * @param string     $attribute     The attribute to batch modify on
-     * @param array|null $values
      *
      * @throws UpdateOperationException on consistency errors during construction
      */

Original file line number	Diff line number	Diff line change
`@@ -124,8 +124,7 @@ private function getConnectionResource()`
`124`	`124`	`}`
`125`	`125`
`126`	`126`	`/**`
`127`		`- * @param string $dn Distinguished name to apply operations on`
`128`		`- * @param iterable\|UpdateOperation[] $operations An array or iterable of Modification instances`
	`127`	`+ * @param iterable\|UpdateOperation[] $operations An array or iterable of UpdateOperation instances`
`129`	`128`	`*`
`130`	`129`	`* @throws UpdateOperationException in case of an error`
`131`	`130`	`*/`
`@@ -137,7 +136,7 @@ public function applyOperations(string $dn, iterable $operations): void`
`137`	`136`	`}`
`138`	`137`
`139`	`138`	`if (!@ldap_modify_batch($this->getConnectionResource(), $dn, $operationsMapped)) {`
`140`		`- throw new UpdateOperationException(sprintf('Error executing batch modification on "%s": "%s".', $dn, ldap_error($this->getConnectionResource())));`
	`139`	`+ throw new UpdateOperationException(sprintf('Error executing UpdateOperation on "%s": "%s".', $dn, ldap_error($this->getConnectionResource())));`
`141`	`140`	`}`
`142`	`141`	`}`
`143`	`142`	`}`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,6 @@ class UpdateOperation`
`29`	`29`	`/**`
`30`	`30`	`* @param int $operationType An LDAP_MODIFY_BATCH_* constant`
`31`	`31`	`* @param string $attribute The attribute to batch modify on`
`32`		`- * @param array\|null $values`
`33`	`32`	`*`
`34`	`33`	`* @throws UpdateOperationException on consistency errors during construction`
`35`	`34`	`*/`