bug #16757 [FrameworkBundle] [Translation] Fixed translations not written when no translations directory in update command (jeremyFreeAgent)

fabpot · fabpot · commit 420da14156fa · 2015-12-08T19:14:24.000+01:00
This PR was merged into the 2.7 branch. Discussion ---------- [FrameworkBundle] [Translation] Fixed translations not written when no translations directory in update command | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Currently when you run the TranslationUpdateCommand and want to write the translation in the domain file without a `translations` directory the output is `[OK] Success` but the file is not created. This PR fix the creation of the directory. Commits ------- 8c45107 [FrameworkBundle] [Translation] Fixed translations not written when no translations directory in update command
diff --git a/src/Symfony/Bundle/FrameworkBundle/Command/TranslationUpdateCommand.php b/src/Symfony/Bundle/FrameworkBundle/Command/TranslationUpdateCommand.php
@@ -188,9 +188,11 @@ protected function execute(InputInterface $input, OutputInterface $output)
                 }
             }
 
-            if ($bundleTransPath) {
-                $writer->writeTranslations($operation->getResult(), $input->getOption('output-format'), array('path' => $bundleTransPath, 'default_locale' => $this->getContainer()->getParameter('kernel.default_locale')));
+            if (!$bundleTransPath) {
+                $bundleTransPath = end($transPaths).'translations';
             }
+
+            $writer->writeTranslations($operation->getResult(), $input->getOption('output-format'), array('path' => $bundleTransPath, 'default_locale' => $this->getContainer()->getParameter('kernel.default_locale')));
         }
 
         $output->newLine();

Original file line number	Diff line number	Diff line change
`@@ -188,9 +188,11 @@ protected function execute(InputInterface $input, OutputInterface $output)`
`188`	`188`	`}`
`189`	`189`	`}`
`190`	`190`
`191`		`- if ($bundleTransPath) {`
`192`		`- $writer->writeTranslations($operation->getResult(), $input->getOption('output-format'), array('path' => $bundleTransPath, 'default_locale' => $this->getContainer()->getParameter('kernel.default_locale')));`
	`191`	`+ if (!$bundleTransPath) {`
	`192`	`+ $bundleTransPath = end($transPaths).'translations';`
`193`	`193`	`}`
	`194`	`+`
	`195`	`+ $writer->writeTranslations($operation->getResult(), $input->getOption('output-format'), array('path' => $bundleTransPath, 'default_locale' => $this->getContainer()->getParameter('kernel.default_locale')));`
`194`	`196`	`}`
`195`	`197`
`196`	`198`	`$output->newLine();`