merged branch Tobion/console-event (PR #8038)

fabpot · fabpot · commit 430c6d748530 · 2013-05-19T21:03:23.000+02:00
This PR was merged into the master branch. Discussion ---------- [Console] ensure integer exit codes in events | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT Commits ------- fe1db71 [Console] ensure integer exit codes in events
diff --git a/src/Symfony/Component/Console/Event/ConsoleCommandEvent.php b/src/Symfony/Component/Console/Event/ConsoleCommandEvent.php
@@ -11,10 +11,6 @@
 
 namespace Symfony\Component\Console\Event;
 
-use Symfony\Component\Console\Command\Command;
-use Symfony\Component\Console\Input\InputInterface;
-use Symfony\Component\Console\Output\OutputInterface;
-
 /**
  * Allows to do things before the command is executed.
  *
diff --git a/src/Symfony/Component/Console/Event/ConsoleForExceptionEvent.php b/src/Symfony/Component/Console/Event/ConsoleForExceptionEvent.php
@@ -30,7 +30,7 @@ public function __construct(Command $command, InputInterface $input, OutputInter
         parent::__construct($command, $input, $output);
 
         $this->setException($exception);
-        $this->exitCode = $exitCode;
+        $this->exitCode = (int) $exitCode;
     }
 
     /**
diff --git a/src/Symfony/Component/Console/Event/ConsoleTerminateEvent.php b/src/Symfony/Component/Console/Event/ConsoleTerminateEvent.php
@@ -43,7 +43,7 @@ public function __construct(Command $command, InputInterface $input, OutputInter
      */
     public function setExitCode($exitCode)
     {
-        $this->exitCode = $exitCode;
+        $this->exitCode = (int) $exitCode;
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -11,10 +11,6 @@`
`11`	`11`
`12`	`12`	`namespace Symfony\Component\Console\Event;`
`13`	`13`
`14`		`-use Symfony\Component\Console\Command\Command;`
`15`		`-use Symfony\Component\Console\Input\InputInterface;`
`16`		`-use Symfony\Component\Console\Output\OutputInterface;`
`17`		`-`
`18`	`14`	`/**`
`19`	`15`	`* Allows to do things before the command is executed.`
`20`	`16`	`*`
Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ public function __construct(Command $command, InputInterface $input, OutputInter`
`30`	`30`	`parent::__construct($command, $input, $output);`
`31`	`31`
`32`	`32`	`$this->setException($exception);`
`33`		`- $this->exitCode = $exitCode;`
	`33`	`+ $this->exitCode = (int) $exitCode;`
`34`	`34`	`}`
`35`	`35`
`36`	`36`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ public function __construct(Command $command, InputInterface $input, OutputInter`
`43`	`43`	`*/`
`44`	`44`	`public function setExitCode($exitCode)`
`45`	`45`	`{`
`46`		`- $this->exitCode = $exitCode;`
	`46`	`+ $this->exitCode = (int) $exitCode;`
`47`	`47`	`}`
`48`	`48`
`49`	`49`	`/**`