minor #31346 [Messenger] Lowercased method calls on \Redis (chalasr)

fabpot · fabpot · commit 446480e2f774 · 2019-05-02T07:45:21.000+02:00
This PR was merged into the 4.3-dev branch. Discussion ---------- [Messenger] Lowercased method calls on \Redis | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #31298 (comment) | License | MIT | Doc PR | n/a https://github.com/phpredis/phpredis/blob/64e71b5307b76f49a71ff43a09e984a80d9a7f12/php_redis.h#L231-L244 Commits ------- 2d41976 [Messenger] Lowercased method calls on \Redis
diff --git a/src/Symfony/Component/Messenger/Transport/RedisExt/Connection.php b/src/Symfony/Component/Messenger/Transport/RedisExt/Connection.php
@@ -79,7 +79,7 @@ public function get(): ?array
 
         $e = null;
         try {
-            $messages = $this->connection->xReadGroup(
+            $messages = $this->connection->xreadgroup(
                 $this->group,
                 $this->consumer,
                 [$this->stream => $messageId],
@@ -119,7 +119,7 @@ public function ack(string $id): void
     {
         $e = null;
         try {
-            $acknowledged = $this->connection->xAck($this->stream, $this->group, [$id]);
+            $acknowledged = $this->connection->xack($this->stream, $this->group, [$id]);
         } catch (\RedisException $e) {
         }
 
@@ -132,7 +132,7 @@ public function reject(string $id): void
     {
         $e = null;
         try {
-            $deleted = $this->connection->xDel($this->stream, [$id]);
+            $deleted = $this->connection->xdel($this->stream, [$id]);
         } catch (\RedisException $e) {
         }
 
@@ -145,7 +145,7 @@ public function add(string $body, array $headers)
     {
         $e = null;
         try {
-            $added = $this->connection->xAdd($this->stream, '*', ['message' => json_encode(
+            $added = $this->connection->xadd($this->stream, '*', ['message' => json_encode(
                 ['body' => $body, 'headers' => $headers]
             )]);
         } catch (\RedisException $e) {
@@ -159,7 +159,7 @@ public function add(string $body, array $headers)
     public function setup(): void
     {
         try {
-            $this->connection->xGroup('CREATE', $this->stream, $this->group, 0, true);
+            $this->connection->xgroup('CREATE', $this->stream, $this->group, 0, true);
         } catch (\RedisException $e) {
             throw new TransportException($e->getMessage(), 0, $e);
         }

Original file line number	Diff line number	Diff line change
`@@ -79,7 +79,7 @@ public function get(): ?array`
`79`	`79`
`80`	`80`	`$e = null;`
`81`	`81`	`try {`
`82`		`- $messages = $this->connection->xReadGroup(`
	`82`	`+ $messages = $this->connection->xreadgroup(`
`83`	`83`	`$this->group,`
`84`	`84`	`$this->consumer,`
`85`	`85`	`[$this->stream => $messageId],`
`@@ -119,7 +119,7 @@ public function ack(string $id): void`
`119`	`119`	`{`
`120`	`120`	`$e = null;`
`121`	`121`	`try {`
`122`		`- $acknowledged = $this->connection->xAck($this->stream, $this->group, [$id]);`
	`122`	`+ $acknowledged = $this->connection->xack($this->stream, $this->group, [$id]);`
`123`	`123`	`} catch (\RedisException $e) {`
`124`	`124`	`}`
`125`	`125`
`@@ -132,7 +132,7 @@ public function reject(string $id): void`
`132`	`132`	`{`
`133`	`133`	`$e = null;`
`134`	`134`	`try {`
`135`		`- $deleted = $this->connection->xDel($this->stream, [$id]);`
	`135`	`+ $deleted = $this->connection->xdel($this->stream, [$id]);`
`136`	`136`	`} catch (\RedisException $e) {`
`137`	`137`	`}`
`138`	`138`
`@@ -145,7 +145,7 @@ public function add(string $body, array $headers)`
`145`	`145`	`{`
`146`	`146`	`$e = null;`
`147`	`147`	`try {`
`148`		`- $added = $this->connection->xAdd($this->stream, '*', ['message' => json_encode(`
	`148`	`+ $added = $this->connection->xadd($this->stream, '*', ['message' => json_encode(`
`149`	`149`	`['body' => $body, 'headers' => $headers]`
`150`	`150`	`)]);`
`151`	`151`	`} catch (\RedisException $e) {`
`@@ -159,7 +159,7 @@ public function add(string $body, array $headers)`
`159`	`159`	`public function setup(): void`
`160`	`160`	`{`
`161`	`161`	`try {`
`162`		`- $this->connection->xGroup('CREATE', $this->stream, $this->group, 0, true);`
	`162`	`+ $this->connection->xgroup('CREATE', $this->stream, $this->group, 0, true);`
`163`	`163`	`} catch (\RedisException $e) {`
`164`	`164`	`throw new TransportException($e->getMessage(), 0, $e);`
`165`	`165`	`}`