[VarDumper] Support ThrownExceptionInformation

jeroennoten · jeroennoten · commit 44848ffa506b · 2020-11-02T08:58:55.000+01:00
diff --git a/src/Symfony/Component/VarDumper/Caster/ExceptionCaster.php b/src/Symfony/Component/VarDumper/Caster/ExceptionCaster.php
@@ -12,6 +12,7 @@
 namespace Symfony\Component\VarDumper\Caster;
 
 use Symfony\Component\ErrorHandler\Exception\SilencedErrorContext;
+use Symfony\Component\Messenger\Exception\ThrownExceptionDetails;
 use Symfony\Component\VarDumper\Cloner\Stub;
 use Symfony\Component\VarDumper\Exception\ThrowingCasterException;
 
@@ -83,6 +84,15 @@ public static function castThrowingCasterException(ThrowingCasterException $e, a
         return $a;
     }
 
+    public static function castThrownExceptionDetails(ThrownExceptionDetails $exceptionDetails, array $a, Stub $stub, bool $isNested, int $filter = 0)
+    {
+        $xPrefix = "\0".ThrownExceptionDetails::class."\0";
+        $stub->class = $exceptionDetails->getClass();
+        unset($a[$xPrefix.'class']);
+
+        return self::filterExceptionArray($exceptionDetails->getClass(), $a, $xPrefix, $filter);
+    }
+
     public static function castSilencedErrorContext(SilencedErrorContext $e, array $a, Stub $stub, bool $isNested)
     {
         $sPrefix = "\0".SilencedErrorContext::class."\0";
diff --git a/src/Symfony/Component/VarDumper/Cloner/AbstractCloner.php b/src/Symfony/Component/VarDumper/Cloner/AbstractCloner.php
@@ -91,6 +91,7 @@ abstract class AbstractCloner implements ClonerInterface
         'Symfony\Component\VarDumper\Caster\FrameStub' => ['Symfony\Component\VarDumper\Caster\ExceptionCaster', 'castFrameStub'],
         'Symfony\Component\VarDumper\Cloner\AbstractCloner' => ['Symfony\Component\VarDumper\Caster\StubCaster', 'cutInternals'],
         'Symfony\Component\ErrorHandler\Exception\SilencedErrorContext' => ['Symfony\Component\VarDumper\Caster\ExceptionCaster', 'castSilencedErrorContext'],
+        'Symfony\Component\Messenger\Exception\ThrownExceptionDetails' => ['Symfony\Component\VarDumper\Caster\ExceptionCaster', 'castThrownExceptionDetails'],
 
         'Imagine\Image\ImageInterface' => ['Symfony\Component\VarDumper\Caster\ImagineCaster', 'castImage'],
 
diff --git a/src/Symfony/Component/VarDumper/Tests/Caster/ExceptionCasterTest.php b/src/Symfony/Component/VarDumper/Tests/Caster/ExceptionCasterTest.php
@@ -244,4 +244,29 @@ public function testAnonymous()
 
         $this->assertDumpMatchesFormat($expectedDump, $e, Caster::EXCLUDE_VERBOSE);
     }
+
+    public function testThrownExceptionDetails()
+    {
+        $e = \Symfony\Component\ErrorHandler\Exception\FlattenException::createFromThrowable($this->getTestException('foo'));
+        $exceptionDetails = \Symfony\Component\Messenger\Exception\ThrownExceptionDetails::createFromFlattenException($e);
+
+        $expectedDump = <<<'EODUMP'
+Exception {
+  -message: "foo"
+  -code: 0
+  -file: "%sExceptionCasterTest.php"
+  -line: 28
+  trace: {
+    %s%eTests%eCaster%eExceptionCasterTest.php:28 {
+      Symfony\Component\VarDumper\Tests\Caster\ExceptionCasterTest->getTestException($msg, &$ref = null)
+      › {
+      ›     return new \Exception(''.$msg);
+      › }
+    }
+    %s%eTests%eCaster%eExceptionCasterTest.php:250 { …}
+%A
+EODUMP;
+
+        $this->assertDumpMatchesFormat($expectedDump, $exceptionDetails);
+    }
 }
diff --git a/src/Symfony/Component/VarDumper/composer.json b/src/Symfony/Component/VarDumper/composer.json
@@ -23,6 +23,7 @@
     "require-dev": {
         "ext-iconv": "*",
         "symfony/console": "^4.4|^5.0",
+        "symfony/error-handliner": "^4.4|^5.0",
         "symfony/process": "^4.4|^5.0",
         "twig/twig": "^2.4|^3.0"
     },
@@ -45,5 +46,10 @@
     "bin": [
         "Resources/bin/var-dump-server"
     ],
-    "minimum-stability": "dev"
+    "minimum-stability": "dev",
+    "extra": {
+        "branch-alias": {
+            "dev-main": "5.3-dev"
+        }
+    }
 }
