Fix infinite recursion when passed an empty string

corphi · corphi · commit 44fb1ff554ca · 2019-01-25T00:16:43.000+01:00
diff --git a/src/Symfony/Component/Security/Core/Authorization/AccessDecisionManager.php b/src/Symfony/Component/Security/Core/Authorization/AccessDecisionManager.php
@@ -43,7 +43,7 @@ class AccessDecisionManager implements AccessDecisionManagerInterface
     public function __construct($voters = [], $strategy = self::STRATEGY_AFFIRMATIVE, $allowIfAllAbstainDecisions = false, $allowIfEqualGrantedDeniedDecisions = true)
     {
         $strategyMethod = 'decide'.ucfirst($strategy);
-        if (!\is_callable([$this, $strategyMethod])) {
+        if (!\is_callable([$this, $strategyMethod]) || \strlen($strategyMethod) === 6) {
             throw new \InvalidArgumentException(sprintf('The strategy "%s" is not supported.', $strategy));
         }
 

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ class AccessDecisionManager implements AccessDecisionManagerInterface`
`43`	`43`	`public function __construct($voters = [], $strategy = self::STRATEGY_AFFIRMATIVE, $allowIfAllAbstainDecisions = false, $allowIfEqualGrantedDeniedDecisions = true)`
`44`	`44`	`{`
`45`	`45`	`$strategyMethod = 'decide'.ucfirst($strategy);`
`46`		`- if (!\is_callable([$this, $strategyMethod])) {`
	`46`	`+ if (!\is_callable([$this, $strategyMethod]) \|\| \strlen($strategyMethod) === 6) {`
`47`	`47`	`throw new \InvalidArgumentException(sprintf('The strategy "%s" is not supported.', $strategy));`
`48`	`48`	`}`
`49`	`49`