minor #15825 Fix potential access to undefined index (Seldaek)

fabpot · fabpot · commit 45b2382f461e · 2015-10-11T10:02:03.000+02:00
This PR was merged into the 2.8 branch. Discussion ---------- Fix potential access to undefined index | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Fixes @Tobion's comment in https://github.com/symfony/symfony/pull/14563/files#r39705270 Commits ------- de41002 Fix potential access to undefined index
diff --git a/src/Symfony/Component/EventDispatcher/EventDispatcher.php b/src/Symfony/Component/EventDispatcher/EventDispatcher.php
@@ -55,7 +55,11 @@ public function dispatch($eventName, Event $event = null)
     public function getListeners($eventName = null, $withPriorities = false)
     {
         if (true === $withPriorities) {
-            return $eventName ? $this->listeners[$eventName] : array_filter($this->listeners);
+            if (null !== $eventName) {
+                return isset($this->listeners[$eventName]) ? $this->listeners[$eventName] : array();
+            }
+
+            return array_filter($this->listeners);
         }
 
         if (null !== $eventName) {

Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,11 @@ public function dispatch($eventName, Event $event = null)`
`55`	`55`	`public function getListeners($eventName = null, $withPriorities = false)`
`56`	`56`	`{`
`57`	`57`	`if (true === $withPriorities) {`
`58`		`- return $eventName ? $this->listeners[$eventName] : array_filter($this->listeners);`
	`58`	`+ if (null !== $eventName) {`
	`59`	`+ return isset($this->listeners[$eventName]) ? $this->listeners[$eventName] : array();`
	`60`	`+ }`
	`61`	`+`
	`62`	`+ return array_filter($this->listeners);`
`59`	`63`	`}`
`60`	`64`
`61`	`65`	`if (null !== $eventName) {`